Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Safe Creation Redesign #864

Closed
12 of 13 tasks
usame-algan opened this issue Jun 9, 2022 · 6 comments · Fixed by #988
Closed
12 of 13 tasks

[Epic] Safe Creation Redesign #864

usame-algan opened this issue Jun 9, 2022 · 6 comments · Fixed by #988
Milestone

Comments

@usame-algan
Copy link
Member

usame-algan commented Jun 9, 2022

Overview

Improving the drop-off rate during safe creation by implementing the new design

Tasks

How to test

  • Open the new route /new-safe/create
  • Click through the steps and compare to the Figma designs
  • Check that the requirements of each subtask is met

Links

Problem statement: safe-global/safe-pm#82
Notion: https://www.notion.so/gnosis-safe/Safe-Creation-7ec069306e8c4101bffd7c17299eec53
Figma: https://www.figma.com/file/ptTs6lDBeUuLNySroJ5PiF/Web-Master-File?node-id=51%3A5661
Analytics: https://analytics.google.com/analytics/web/#/analysis/p308247657/edit/h41dtVeqQ0icP3o_O_Cx-g

@usame-algan usame-algan self-assigned this Jun 9, 2022
@usame-algan usame-algan changed the title [EPIC] Improve Safe Creation flow to reduce drop-off rate [Epic] Improve Safe Creation flow to reduce drop-off rate Jun 9, 2022
@usame-algan usame-algan changed the title [Epic] Improve Safe Creation flow to reduce drop-off rate [Epic] Improve Safe Creation flow after tx execution to reduce drop-off rate Jun 9, 2022
@usame-algan usame-algan changed the title [Epic] Improve Safe Creation flow after tx execution to reduce drop-off rate [Epic] Improve Safe Creation flow after tx execution Jun 9, 2022
@katspaugh katspaugh transferred this issue from 5afe/safe-react Oct 10, 2022
@usame-algan usame-algan changed the title [Epic] Improve Safe Creation flow after tx execution [Epic] Safe Creation Redesign Oct 18, 2022
@katspaugh katspaugh moved this to Todo in Web Squad Oct 26, 2022
@usame-algan usame-algan moved this from Todo to In Progress in Web Squad Oct 26, 2022
@usame-algan usame-algan linked a pull request Oct 26, 2022 that will close this issue
@usame-algan usame-algan removed their assignment Oct 28, 2022
@johannesmoormann johannesmoormann moved this from In Progress to Ready for QA in Web Squad Nov 9, 2022
@francovenica francovenica moved this from Ready for QA to QA in progress in Web Squad Nov 11, 2022
@francovenica francovenica moved this from QA in progress to Ready for QA in Web Squad Nov 14, 2022
@rmeissner rmeissner added this to the v1.0.4 milestone Nov 16, 2022
@francovenica francovenica moved this from Ready for QA to QA in progress in Web Squad Nov 16, 2022
@francovenica
Copy link
Contributor

Question.
The previous iteration of safe creation would put as the first owner the currently connected wallet, and if you changed wallet it would replace that first row with it. Was that feature dropped?

@francovenica
Copy link
Contributor

Question/suggestion : In the review step (step 4) the addresses don't have the copy to clipboard/blockexplorer icons. They are not in the design, but we put it everywhere in the app, we should probably put them here too

@francovenica
Copy link
Contributor

Question:
In the designs it seems to be a way to complete cancel the safe creation, but in any of the step, not even step one, there is a "Cancel". Was decided to not put a way to exit the safe creation?
Currently, the only way for the user to get out is using the logo on the top left (which is not even that good, since that if the user has a "last used safe" it will take him there first)

@francovenica francovenica moved this from QA in progress to In Progress in Web Squad Nov 17, 2022
@francovenica francovenica moved this from In Progress to QA in progress in Web Squad Nov 17, 2022
@usame-algan
Copy link
Member Author

usame-algan commented Nov 18, 2022

The previous iteration of safe creation would put as the first owner the currently connected wallet, and if you changed wallet it would replace that first row with it. Was that feature dropped?

Yes, we decided to change it because it would allow creating a safe for a different wallet than the connected one e.g. a user wants to create a safe with one owner that is not his wallet. So initially the connected wallet is set as an owner only once now and can be changed.

In the review step (step 4) the addresses don't have the copy to clipboard/blockexplorer icons. They are not in the design, but we put it everywhere in the app, we should probably put them here too

Makes sense! I will add links there as well. Edit: This should now be merged here and can be tested

@francovenica
Copy link
Contributor

I've been checking the GTM with the old and new safe creation. The only noticeable difference is that from the "owner" step to the next there are 2 metadatas (Owners and policies).
This image is from current prod web-core. These 2 metadata are not being tracked in the new safe creation flow
image

Also we are not tracking anything regarding the new tips in the right side of the safe creation (if the user clicks them or not). I think we should since the idea is to know if the users are paying attention to them or not.
image

@francovenica
Copy link
Contributor

Tested here since it was the last build shared with me
The Switching between the worked but it might take several clears of the LS to see it.
Tried the old flow several times and it worked fine

The safe creation epic looks good to me

@francovenica francovenica moved this from QA in progress to QA done in Web Squad Nov 24, 2022
Repository owner moved this from QA done to Done in Web Squad Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants