Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

fix: Track more safe creation steps #3965

Merged
merged 4 commits into from
Jun 15, 2022
Merged

fix: Track more safe creation steps #3965

merged 4 commits into from
Jun 15, 2022

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jun 13, 2022

What it solves

Part of safe-global/safe-wallet-monorepo#864

How this PR fixes it

Adds additional tracking for Safe Creation:

  • Tx was submitted by user
  • Tx was rejected by user
  • Safe Creation was canceled
  • Safe Created was retried

Removes the "Back" Button that is displayed after the tx is submitted.

How to test it

  1. Open the Safe app
  2. Create a new Safe
  3. Observe GTM Events being sent when rejecting/submitting the Tx in the wallet provider
  4. Observe GTM Events being sent when clicking Retry or Cancel
  5. Observe no Back Button in the Footer after Tx Submission

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jun 13, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

src/utils/events/createLoadSafe.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

Deployment links

Mainnet     🟣 Polygon     🟠 Rinkeby

@coveralls
Copy link

coveralls commented Jun 13, 2022

Pull Request Test Coverage Report for Build 2501471841

  • 0 of 5 (0.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 36.8%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/opening/index.tsx 0 2 0.0%
src/routes/CreateSafePage/components/SafeCreationProcess.tsx 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/routes/opening/index.tsx 1 7.04%
src/routes/CreateSafePage/components/SafeCreationProcess.tsx 2 7.14%
src/components/App/ReceiveModal.tsx 4 0%
Totals Coverage Status
Change from base Build 2487795864: 0.1%
Covered Lines: 3862
Relevant Lines: 9544

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jun 13, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

@francovenica
Copy link
Contributor

Ok, I found the new events.
Safe Create is trigger with the response MM gives after signing the safe creation
Safe Reject is triggered with the response MM gives after hitting Reject
Safe Retry is tracked as soon as you hit retry in the
Safe Cancel is triggered when the user hits the cancel button (the safe creation fails, cancel and retry buttons are displayed) or when the "Back" button is hit

There was some discussion here because hitting the "Back" button technically is not a cancelation, the button shows up once the tx was singed and the safe will be created regardless if the user hits back or not, so probably the button triggering the "Safe cancel" event is technically not correct.

I know there is a task to remove the back button altogether, but the button was put there in case the user gets stuck in the safe creation process (if the safe takes too long to finish for example) since if he tries to reopen the create form it will be taken to the automatic steps again.

@usame-algan
Copy link
Member Author

I know there is a task to remove the back button altogether, but the button was put there in case the user gets stuck in the safe creation process (if the safe takes too long to finish for example) since if he tries to reopen the create form it will be taken to the automatic steps again.

I would say that instead of giving the user an option to "unstuck" at that point, we should provide more information since an action outside of the safe app is required i.e. speeding up or canceling the transaction. Otherwise it can happen that the transaction is picked up at a later time and a new safe appears in the sidebar which is unexpected. I added a task for this to the Epic and would go ahead with removing the back button. cc @johannesmoormann

@francovenica
Copy link
Contributor

The back button was removed. Looks good to me

@usame-algan usame-algan merged commit b83b3e4 into dev Jun 15, 2022
@usame-algan usame-algan deleted the track-create-safe branch June 15, 2022 12:22
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants