You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ok, I found the new events.
Safe Create is trigger with the response MM gives after signing the safe creation
Safe Reject is triggered with the response MM gives after hitting Reject
Safe Retry is tracked as soon as you hit retry in the
Safe Cancel is triggered when the user hits the cancel button (the safe creation fails, cancel and retry buttons are displayed) or when the "Back" button is hit
There was some discussion here because hitting the "Back" button technically is not a cancelation, the button shows up once the tx was singed and the safe will be created regardless if the user hits back or not, so probably the button triggering the "Safe cancel" event is technically not correct.
I know there is a task to remove the back button altogether, but the button was put there in case the user gets stuck in the safe creation process (if the safe takes too long to finish for example) since if he tries to reopen the create form it will be taken to the automatic steps again.
I know there is a task to remove the back button altogether, but the button was put there in case the user gets stuck in the safe creation process (if the safe takes too long to finish for example) since if he tries to reopen the create form it will be taken to the automatic steps again.
I would say that instead of giving the user an option to "unstuck" at that point, we should provide more information since an action outside of the safe app is required i.e. speeding up or canceling the transaction. Otherwise it can happen that the transaction is picked up at a later time and a new safe appears in the sidebar which is unexpected. I added a task for this to the Epic and would go ahead with removing the back button. cc @johannesmoormann
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it solves
Part of safe-global/safe-wallet-monorepo#864
How this PR fixes it
Adds additional tracking for Safe Creation:
Removes the "Back" Button that is displayed after the tx is submitted.
How to test it