Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[safe creation]failed creation screen UI issues #1175

Closed
liliya-soroka opened this issue Nov 16, 2022 · 1 comment
Closed

[safe creation]failed creation screen UI issues #1175

liliya-soroka opened this issue Nov 16, 2022 · 1 comment
Assignees
@usame-algan
Labels
bug Something isn't working minor Minor bug

Comments

@liliya-soroka
Copy link
Member

liliya-soroka commented Nov 16, 2022 •
edited
Loading

Bug description

There are some diff from the design on the "failed creation" screen:

  1. color of the message: the green on the design, the red after implementation
  2. the position of the buttons is wrong

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Ethereum mainnet

Steps to reproduce

  1. Go to safe creation flow
  2. go to the last step
  3. click to submit to the wallet for signing
  4. reject in the wallet

Expected result

image

Screenshots

image

relates to #864
@liliya-soroka liliya-soroka added bug Something isn't working minor Minor bug labels Nov 16, 2022
@liliya-soroka liliya-soroka moved this to Todo in Safe{Wallet} Nov 16, 2022
@usame-algan usame-algan moved this from Todo to In Progress in Safe{Wallet} Nov 21, 2022
@usame-algan usame-algan self-assigned this Nov 21, 2022
@usame-algan usame-algan mentioned this issue Nov 21, 2022
Merged
@usame-algan usame-algan moved this from In Progress to Peer Review in Safe{Wallet} Nov 21, 2022
@usame-algan usame-algan moved this from Peer Review to Ready for QA in Safe{Wallet} Nov 21, 2022
@francovenica
Copy link
Contributor

Looks good:
image

@francovenica francovenica moved this from Ready for QA to QA done in Safe{Wallet} Nov 22, 2022
Repository owner moved this from QA done to Done in Safe{Wallet} Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usame-algan usame-algan

Labels
bug Something isn't working minor Minor bug
Projects
Safe{Wallet}
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liliya-soroka @francovenica @usame-algan