Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Create safe] Switching chains while a safe is being created displaying information about that safe on other chains #1095

Closed
JagoFigueroa opened this issue Nov 8, 2022 · 1 comment
Labels
bug Something isn't working major Major bug (to be solved in the next release)

Comments

@JagoFigueroa
Copy link

JagoFigueroa commented Nov 8, 2022

Bug description

A bit tricky. While a safe is being created, if we switch to another chain, information will be displayed as if we were creating a safe on the new chain that it was selected when that is not true & will block users from creating new safes on other chains while the current one is being processed.

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Any

Steps to reproduce

  1. Create a safe with a gas limit low enough so that it wont finish creating
  2. Switch to another chain

In my case I was able to reproduce this on Optimism while the chain was being slow and wanted to continue creating safes on other chains on the meanwhile but I couldn't because of this inheritance.

Expected result

I am able to create a new safe in other chains while the one from Optimism (taking my case as reference) is stuck on creation.

Obtained result

safe.creation.mp4
@JagoFigueroa JagoFigueroa added bug Something isn't working major Major bug (to be solved in the next release) labels Nov 8, 2022
@JagoFigueroa JagoFigueroa moved this to Todo in Safe{Wallet} Nov 8, 2022
@iamacook
Copy link
Member

iamacook commented Nov 8, 2022

I will close this as we have almost finished our implementation of the redesigned Safe creation.

@iamacook iamacook closed this as completed Nov 8, 2022
Repository owner moved this from Todo to Done in Safe{Wallet} Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major Major bug (to be solved in the next release)
Projects
Archived in project
Development

No branches or pull requests

2 participants