Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Safe creation] Uploading a non-QR code image for owner crashes the page #1185

Closed
francovenica opened this issue Nov 17, 2022 · 1 comment
Closed

[Safe creation] Uploading a non-QR code image for owner crashes the page #1185

francovenica opened this issue Nov 17, 2022 · 1 comment
Assignees
@usame-algan
Labels
bug Something isn't working major Major bug (to be solved in the next release)

Comments

@francovenica
Copy link
Contributor

Bug description

Trying a png that is not a QR code and then trying to upload something again makes the page crash after a while (I think there is an infinite loop here)

Environment

Steps to reproduce

  1. Go to Owner step for safe creation
  2. Upload a non-QR code image
  3. Click "Upload image" again
  4. Try to pick another image from your folder

Expected result

If picked another image this is uploaded an if it is a valid QR it reads it as the address
If it is not a valid QR shows the error again

Obtained result

The Tab freezes and after a while the browser ask you to close the page (infinite loop probably)

Screenshots

Frozen page
@francovenica francovenica added the bug Something isn't working label Nov 17, 2022
@liliya-soroka liliya-soroka moved this to Todo in Web Squad Nov 17, 2022
@liliya-soroka liliya-soroka added the major Major bug (to be solved in the next release) label Nov 17, 2022
@usame-algan usame-algan moved this from Todo to In Progress in Web Squad Nov 18, 2022
@usame-algan usame-algan self-assigned this Nov 18, 2022
@usame-algan usame-algan mentioned this issue Nov 18, 2022
Merged
@usame-algan usame-algan moved this from In Progress to Peer Review in Web Squad Nov 18, 2022
@usame-algan usame-algan moved this from Peer Review to Ready for QA in Web Squad Nov 19, 2022
@francovenica
Copy link
Contributor Author

fixed and merged in the epic

@francovenica francovenica moved this from Ready for QA to QA done in Web Squad Nov 21, 2022
Repository owner moved this from QA done to Done in Web Squad Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usame-algan usame-algan

Labels
bug Something isn't working major Major bug (to be solved in the next release)
Projects
Web Squad
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liliya-soroka @francovenica @usame-algan