[Epic] Safe Creation #988

usame-algan · 2022-10-26T15:05:40Z

What it solves

Resolves #864

github-actions · 2022-10-26T15:09:24Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

* feat: basic step 2 implementation Co-authored-by: iamacook <[email protected]>

* feat: creation info widget * fix: Remove demo page Co-authored-by: Usame Algan <[email protected]>

A new CardStepper component which controls the steps for new safe creation which can - go back and forth - jump to a specific step - set an initial step - set initial values - renders a progress bar - step data is stored in an object with a generic type - the update functions (onBack, onSubmit) use Partials of that type such that each step does not need to submit the full data change /demo route to /create-safe Co-authored-by: Usame Algan <[email protected]>

* feat: new create safe review step * calculate total gas fee * fill the form values * refactor review rows * fix: implement Figma designs * fix: background-color on network fee * avoid infinite rerendering * integrate review step in new Stepper * style: visual tweaks

* fix: Create safe layout adjustments * fix: overview widget margin top * fix: Move overview widget to top on mobile

* feat: AB testing system * fix: remove reset function + test `AbTest` value * Refactor: sync useLocalStorage across components and tabs (#977) * Refactor: external store in useLocalStorage * Comment * Sync separately * Use the storage event for syncing * Rm comment * Restore prev behavior wrt undefined * Simplify the undefined check * Allow undefined and rm initialValue * Don't set undefined * Local storage to return null when not found * Initial value * Rm initial value again * usePendingCreation * Rm redundant code * Refactor: external store in useLocalStorage (#1014) Refactor: external store in useLocalStorage * feat: create `useABTesting` hook for setting event * fix: reorganise structure Co-authored-by: katspaugh <[email protected]>

* fix: Add connect wallet step to safe creation * fix: Remove unused method * fix: Reuse components, adjust modal zIndex * fix: Only run onConnect callback if there was no error when connecting a wallet * fix: Set wallet owner in form on connect * fix: Check for connected wallet * style: Use onboard zindex variable

* add overview and CreateSafeInfo widget - displays safe name and connected wallet during owner setup - displays hints for each step + dynamic hints during owner and threshold setup - state is pulled up into the CreateSafe component and update functions passed into the owner step * step static tips are collapsed by default * navigate tips logic * reverse expanded logic * restyle InfoWidget * remove the add mobile owner row * remove flickering when opening the accordion * fix keys * add hover style to the Accordion expand icon * Accordion summary bold when expanded * style: PR comments * fix empty form data name * simplify map key * link to Safe setup article * change allOwners logic * mv sx to css modules * add current chain in Overview widget Co-authored-by: Diogo Soares <[email protected]>

github-actions · 2022-11-03T12:27:24Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

* feat: Implement create safe status redesign * style: Add animated loading spinner * fix: Simplify conditions * add: animate into css safe logo * fix: use numeric enum for simpler conditions, adjust animated logo sizes * fix: Display dialog after safe creation * fix: Feedback * fix: Better name for query param Co-authored-by: schmanu <[email protected]>

* add link to tip * add missing tooltips * update copy * use SvgIcon to inherit viewBox * fix: inherit `fill` Co-authored-by: iamacook <[email protected]>

* style: Safe Creation layout * fix: Align threshold text

* fix: Handle wallet connection when creating safe * fix: Only watch threshold * refactor: Rename useSetCreationStep to useSyncSafeCreationStep * fix: Use formState.isValid * fix: Add tests for useSyncSafeCreationStep

* fix: Show error notifications in safe creation * fix: Add closeByGroupKey action to notification slice

* fix: Navigate back to the welcome page on cancel * fix: Reuse NameInput for new form * fix: Use currentColor for icons

github-actions · 2022-11-17T08:17:33Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

* fix: reduce threshold when removing owner * fix: use enum for all field names * fix: reduce code

* fix: Update text and layout for step 0 * fix: Update text for step 2 and 3, show copy and explorer icons for addresses * fix: Update text for status messages * fix: Update hint texts * fix: Update creation modal text, add dynamic values

* fix: Safe Creation color issues * chore: Add TODO * fix: Remove static colors and use palette directly

* fix: Add missing safe creation events * fix: Add new events for hints

* fix: Watch safe creation tx even without a connected wallet * fix it in the old safe creation flow too * fix: failing test * fix: Add additional test

github-actions · 2022-11-22T15:33:49Z

Branch preview

https://pr988--webcore.review-react-br.5afe.dev

* fix: Only watch safe creation tx once * fix: Detect if tx reverted when ethers throws error

* refactor: Remove unused code that was duplicated * fix: Revert ab test removal * refactor: Remove unused StepCard component * fix: Update links to safe.global * fix: Set link to safe creation for ab testing

github-actions · 2022-11-23T16:51:10Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

* fix: Safe cration text changes * fix: Adjust safe indexed message

DiogoSoaress

🚀

schmanu

Yayy 🚀

usame-algan linked an issue Oct 26, 2022 that may be closed by this pull request

[Epic] Safe Creation Redesign #864

Closed

13 tasks

usame-algan changed the title ~~feat: Safe Creation~~ [Epic] Safe Creation Oct 26, 2022

iamacook and others added 8 commits October 27, 2022 16:20

feat: new creation design + step 1

ee0d266

fix: widget width

c1b9731

refactor: combine components

649be2c

fix: rename folder + remove CSS module

399563f

fix: missing padding

96bb532

fix: Reuse NetworkSelector component

06f2718

[Safe Creation] Owner step (#989)

fa66271

* feat: basic step 2 implementation Co-authored-by: iamacook <[email protected]>

feat: creation info widget (#960)

614ee1b

* feat: creation info widget * fix: Remove demo page Co-authored-by: Usame Algan <[email protected]>

usame-algan force-pushed the creation branch from 22e17a7 to 614ee1b Compare October 27, 2022 14:20

schmanu and others added 8 commits October 27, 2022 18:22

fix: Create safe layout adjustments (#997)

8c0931c

* fix: Create safe layout adjustments * fix: overview widget margin top * fix: Move overview widget to top on mobile

Merge branch 'dev' into creation

e5b6176

feat: add AB testing to Safe creation (#1017)

ba2f7ca

usame-algan and others added 8 commits November 4, 2022 12:27

[Safe creation] Creation links tooltips (#1061)

bd444dc

* add link to tip * add missing tooltips * update copy * use SvgIcon to inherit viewBox * fix: inherit `fill` Co-authored-by: iamacook <[email protected]>

fix: textual inconsistencies + add hint (#1065)

76fd913

[Safe Creation] Layout adjustments (#1063)

a130210

* style: Safe Creation layout * fix: Align threshold text

[Create Safe] Handle wallet connection (#1087)

a7ee64d

* fix: Handle wallet connection when creating safe * fix: Only watch threshold * refactor: Rename useSetCreationStep to useSyncSafeCreationStep * fix: Use formState.isValid * fix: Add tests for useSyncSafeCreationStep

fix: Show error notifications in safe creation (#1135)

24575fc

* fix: Show error notifications in safe creation * fix: Add closeByGroupKey action to notification slice

fix: Safe creation issues (#1180)

394a1d7

* fix: Navigate back to the welcome page on cancel * fix: Reuse NameInput for new form * fix: Use currentColor for icons

Merge remote-tracking branch 'origin/dev' into creation

92815bb

iamacook and others added 8 commits November 18, 2022 10:36

fix: reduce threshold when removing owner (#1181)

18482b8

* fix: reduce threshold when removing owner * fix: use enum for all field names * fix: reduce code

Safe creation text updates (#1198)

477e0b2

* fix: Update text and layout for step 0 * fix: Update text for step 2 and 3, show copy and explorer icons for addresses * fix: Update text for status messages * fix: Update hint texts * fix: Update creation modal text, add dynamic values

fix: QR reader crashes app (#1200)

bd68151

fix: Safe Creation color issues (#1204)

0915f52

* fix: Safe Creation color issues * chore: Add TODO * fix: Remove static colors and use palette directly

fix: Add overview widget to step 1 in safe creation (#1210)

0bf18e1

fix: Add missing safe creation events (#1212)

4a10f47

* fix: Add missing safe creation events * fix: Add new events for hints

fix: Watch safe creation tx even without a connected wallet (#1215)

60b7df3

* fix: Watch safe creation tx even without a connected wallet * fix it in the old safe creation flow too * fix: failing test * fix: Add additional test

Merge remote-tracking branch 'origin/dev' into creation

309f8f0

fix: Only watch safe creation tx once (#1223)

8d630f3

* fix: Only watch safe creation tx once * fix: Detect if tx reverted when ethers throws error

usame-algan marked this pull request as ready for review November 23, 2022 10:23

safe-global deleted a comment from cloudflare-workers-and-pages bot Nov 23, 2022

usame-algan and others added 3 commits November 23, 2022 17:13

refactor: Remove unused code that was duplicated (#1230)

e2587ae

* refactor: Remove unused code that was duplicated * fix: Revert ab test removal * refactor: Remove unused StepCard component * fix: Update links to safe.global * fix: Set link to safe creation for ab testing

Merge remote-tracking branch 'origin/dev' into creation

99c5ce0

fix: Hide sidebar on safe creation

3dddd54

usame-algan and others added 3 commits November 24, 2022 10:24

fix: Revert ab test change

39cd835

fix: Center QR code reload icon

5bf3a52

fix: Safe cration text changes (#1239)

6507814

* fix: Safe cration text changes * fix: Adjust safe indexed message

usame-algan requested review from iamacook, DiogoSoaress, schmanu and katspaugh November 24, 2022 15:22

fix: Adjust safe indexed message

9d9354c

DiogoSoaress approved these changes Nov 24, 2022

View reviewed changes

katspaugh approved these changes Nov 24, 2022

View reviewed changes

schmanu approved these changes Nov 24, 2022

View reviewed changes

usame-algan merged commit 03135e8 into dev Nov 24, 2022

usame-algan deleted the creation branch November 24, 2022 16:25

katspaugh mentioned this pull request Nov 28, 2022

Release v1.1.0 #1255

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Epic] Safe Creation #988

[Epic] Safe Creation #988

usame-algan commented Oct 26, 2022

github-actions bot commented Oct 26, 2022 •

edited

Loading

github-actions bot commented Nov 3, 2022 •

edited

Loading

github-actions bot commented Nov 17, 2022 •

edited

Loading

github-actions bot commented Nov 22, 2022

github-actions bot commented Nov 23, 2022 •

edited

Loading

DiogoSoaress left a comment

schmanu left a comment

[Epic] Safe Creation #988

[Epic] Safe Creation #988

Conversation

usame-algan commented Oct 26, 2022

What it solves

github-actions bot commented Oct 26, 2022 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Nov 3, 2022 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Nov 17, 2022 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Nov 22, 2022

Branch preview

github-actions bot commented Nov 23, 2022 • edited Loading

ESLint Summary View Full Report

DiogoSoaress left a comment

Choose a reason for hiding this comment

schmanu left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 26, 2022 •

edited

Loading

github-actions bot commented Nov 3, 2022 •

edited

Loading

github-actions bot commented Nov 17, 2022 •

edited

Loading

github-actions bot commented Nov 23, 2022 •

edited

Loading