Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[safe creation] Cancel button on the failed screen is not cancel the whole process #1177

Closed
liliya-soroka opened this issue Nov 16, 2022 · 0 comments
Closed

[safe creation] Cancel button on the failed screen is not cancel the whole process #1177

liliya-soroka opened this issue Nov 16, 2022 · 0 comments
Assignees
@usame-algan
Labels
bug Something isn't working minor Minor bug

Comments

@liliya-soroka
Copy link
Member

Bug description

Cancel button on the failed screen is not cancel the whole process

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Goerli

Steps to reproduce

  1. Go to https://creation.web-core.pages.dev/new-safe/create
  2. go through the safe creation flow
  3. reject the safe creation in the wallet
  4. click Cancel
    Current result: The user is located on the first or second step of the safe creation flow

Expected result

The user should be navigating out of the safe creation flow completely

Relates to #864
@liliya-soroka liliya-soroka added bug Something isn't working minor Minor bug labels Nov 16, 2022
@liliya-soroka liliya-soroka moved this to Todo in Web Squad Nov 16, 2022
@usame-algan usame-algan moved this from Todo to In Progress in Web Squad Nov 16, 2022
@usame-algan usame-algan self-assigned this Nov 16, 2022
@usame-algan usame-algan mentioned this issue Nov 16, 2022
Merged
@usame-algan usame-algan moved this from In Progress to Peer Review in Web Squad Nov 16, 2022
Repository owner moved this from Peer Review to Done in Web Squad Nov 17, 2022
@usame-algan usame-algan moved this from Done to Ready for QA in Web Squad Nov 17, 2022
@francovenica francovenica moved this from Ready for QA to QA done in Web Squad Nov 17, 2022
@usame-algan usame-algan moved this from QA done to Done in Web Squad Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usame-algan usame-algan

Labels
bug Something isn't working minor Minor bug
Projects
Web Squad
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liliya-soroka @usame-algan