Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stepper is not tracking current step #1248

Closed
usame-algan opened this issue Nov 25, 2022 · 0 comments · Fixed by #1249
Closed

Stepper is not tracking current step #1248

usame-algan opened this issue Nov 25, 2022 · 0 comments · Fixed by #1249
Assignees
@usame-algan
Labels
bug Something isn't working

Comments

@usame-algan
Copy link
Member

Bug description

The stepper events that are sent when going to the next or previous step do not include the step number

This is needed for #864

Steps to reproduce

  1. Go to Safe creation
  2. Click Next
  3. Observe the eventLabel from the event does not contain the current step number

Expected result

The events should include the current step number
@usame-algan usame-algan added the bug Something isn't working label Nov 25, 2022
@usame-algan usame-algan moved this to Todo in Safe{Wallet} Nov 25, 2022
@usame-algan usame-algan moved this from Todo to In Progress in Safe{Wallet} Nov 25, 2022
@usame-algan usame-algan self-assigned this Nov 25, 2022
@usame-algan usame-algan mentioned this issue Nov 25, 2022
Merged
@usame-algan usame-algan moved this from In Progress to Peer Review in Safe{Wallet} Nov 25, 2022
@usame-algan usame-algan moved this from Peer Review to Ready for QA in Safe{Wallet} Nov 25, 2022
Repository owner moved this from Ready for QA to Done in Safe{Wallet} Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usame-algan usame-algan

Labels
bug Something isn't working
Projects
Safe{Wallet}
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Send current step with tracking event safe-global/safe-wallet-monorepo
1 participant
@usame-algan