Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Safe creation]Threshold number is missed when the owner is deleted from the step 3 if threshold=max number #1178

Closed
liliya-soroka opened this issue Nov 16, 2022 · 1 comment · Fixed by #1181
Closed

[Safe creation]Threshold number is missed when the owner is deleted from the step 3 if threshold=max number #1178

liliya-soroka opened this issue Nov 16, 2022 · 1 comment · Fixed by #1181
Assignees
@iamacook
Labels
bug Something isn't working major Major bug (to be solved in the next release)

Comments

@liliya-soroka
Copy link
Member

liliya-soroka commented Nov 16, 2022 •
edited
Loading

Bug description

Threshold number is missed if the owner is deleted from the step 3 but the old max threshold is used on the review screen in safe configuration

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain:Goerli

Steps to reproduce

  1. Go to safe creation flow
  2. go to the safe owners step
  3. add 2 owners
  4. set up threshold as 2
  5. remove one owner
    Current result: The setup threshold is empty.

image

image

Expected result

the threshold should take into account removed owner if it was set up to the max available number

relates to : #864
@liliya-soroka liliya-soroka added bug Something isn't working minor Minor bug labels Nov 16, 2022
@liliya-soroka liliya-soroka moved this to Todo in Web Squad Nov 16, 2022
@liliya-soroka liliya-soroka added major Major bug (to be solved in the next release) and removed minor Minor bug labels Nov 16, 2022
@iamacook iamacook self-assigned this Nov 16, 2022
@iamacook iamacook moved this from Todo to In Progress in Web Squad Nov 16, 2022
@iamacook iamacook mentioned this issue Nov 16, 2022
Merged
@iamacook iamacook moved this from In Progress to Peer Review in Web Squad Nov 16, 2022
@iamacook iamacook linked a pull request Nov 16, 2022 that will close this issue
fix: reduce threshold when removing owner #1181
Merged
@iamacook iamacook moved this from Peer Review to Ready for QA in Web Squad Nov 17, 2022
@francovenica
Copy link
Contributor

LGTM

@francovenica francovenica moved this from Ready for QA to QA done in Web Squad Nov 18, 2022
Repository owner moved this from QA done to Done in Web Squad Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamacook iamacook

Labels
bug Something isn't working major Major bug (to be solved in the next release)
Projects
Web Squad
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reduce threshold when removing owner safe-global/safe-wallet-monorepo
4 participants
@liliya-soroka @francovenica @usame-algan @iamacook