Add conversion metric rendering tests #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 15, 2024
tlento
force-pushed
the
add-conversion-metric-rendering-tests
branch
from
876b8fd to
5ee3296
Compare
tlento
added
the
Run Tests With Other SQL Engines
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
tlento
force-pushed
the
add-conversion-metric-rendering-tests
branch
from
5ee3296 to
7aa7f5e
Compare
tlento
force-pushed
the
add-conversion-metric-rendering-tests
branch
from
7aa7f5e to
fc69e24
Compare
This was referenced May 22, 2024
We do not have rendering tests for conversion metrics, nor do we have any tests with query-time filters added. This change addresses both of these gaps in our coverage, which will give us more confidence as we move ahead with predicate pushdown.
tlento
force-pushed
the
add-conversion-metric-rendering-tests
branch
from
fc69e24 to
820afa1
Compare
tlento
added
the
Run Tests With Other SQL Engines
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
This was referenced Jun 12, 2024
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conversion metric rendering tests
We do not have rendering tests for conversion metrics, nor do we
have any tests with query-time filters added.
This change addresses both of these gaps in our coverage, which will
give us more confidence as we move ahead with predicate pushdown.
Add snapshots for all engines