-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename PredicatePushdownParameters to PredicatePushdownState #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This was referenced May 22, 2024
courtneyholcomb
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable!
tlento
force-pushed
the
make-source-semantic-models-available-from-nodes
branch
from
May 23, 2024 23:41
9ef3244
to
45cf01f
Compare
tlento
force-pushed
the
rename-predicate-pushdown-params
branch
from
May 23, 2024 23:41
dad601d
to
7882c02
Compare
tlento
force-pushed
the
make-source-semantic-models-available-from-nodes
branch
from
May 24, 2024 00:47
45cf01f
to
f0c6cb9
Compare
Base automatically changed from
make-source-semantic-models-available-from-nodes
to
main
May 24, 2024 00:52
The PredicatePushdownParameters class is really a state tracking container to help us determine whether and how to do predicate pushdown, o we update the name to match its function.
tlento
force-pushed
the
rename-predicate-pushdown-params
branch
from
May 24, 2024 00:52
7882c02
to
508cfb9
Compare
This was referenced Jun 12, 2024
This was referenced Jun 14, 2024
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename PredicatePushdownParameters to PredicatePushdownState
The PredicatePushdownParameters class is really a state tracking
container to help us determine whether and how to do predicate pushdown,
o we update the name to match its function.
Update pushdown_params -> pushdown_state
Straggling renames plus documentation updates