Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SourceScanOptimizer in query rendering tests #1306

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Jun 25, 2024

Enable SourceScanOptimizer in query rendering tests

The query rendering test suite recently added support for
DataflowPlanOptimizer usage, but that only included the
PredicatePushdownOptimizer to support development.

Now that we are getting ready to release we need to see how the
queries come out with all optimizers in place, so we add the
missing SourceScanOptimizer to the set.

Update SQL engine snapshots

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor Author

tlento commented Jun 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlento and the rest of your teammates on Graphite Graphite

@tlento tlento force-pushed the add-sql-rendering-tests-for-pushdown-edge-cases branch from fed6421 to 27328d4 Compare June 26, 2024 00:15
@tlento tlento force-pushed the enable-source-scan-optimizer-in-rendering-tests branch from 75ff8a2 to f66e1bb Compare June 26, 2024 00:15
Copy link
Contributor Author

tlento commented Jun 26, 2024

Merge activity

  • Jun 25, 5:24 PM PDT: @tlento started a stack merge that includes this pull request via Graphite.
  • Jun 25, 5:50 PM PDT: Graphite rebased this pull request as part of a merge.
  • Jun 25, 5:53 PM PDT: @tlento merged this pull request with Graphite.

@tlento tlento force-pushed the add-sql-rendering-tests-for-pushdown-edge-cases branch from 27328d4 to 7975146 Compare June 26, 2024 00:44
Base automatically changed from add-sql-rendering-tests-for-pushdown-edge-cases to main June 26, 2024 00:48
tlento added 2 commits June 26, 2024 00:49
The query rendering test suite recently added support for
DataflowPlanOptimizer usage, but that only included the
PredicatePushdownOptimizer to support development.

Now that we are getting ready to release we need to see how the
queries come out with all optimizers in place, so we add the
missing SourceScanOptimizer to the set.
@tlento tlento force-pushed the enable-source-scan-optimizer-in-rendering-tests branch from f66e1bb to 61de816 Compare June 26, 2024 00:49
@tlento tlento merged commit 3fb97c8 into main Jun 26, 2024
15 checks passed
@tlento tlento deleted the enable-source-scan-optimizer-in-rendering-tests branch June 26, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants