Add SQL rendering tests for pushdown edge cases #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This was referenced Jun 25, 2024
This was referenced Jun 25, 2024
...g.py/SqlQueryPlan/DuckDB/test_cumulative_metric_with_query_time_filters__plan0_optimized.sql
Show resolved
Hide resolved
...qlQueryPlan/DuckDB/test_fill_nulls_time_spine_metric_predicate_pushdown__plan0_optimized.sql
Show resolved
Hide resolved
...ndering.py/SqlQueryPlan/DuckDB/test_metric_time_filter_with_two_targets__plan0_optimized.sql
Show resolved
Hide resolved
...yPlan/DuckDB/test_simple_join_to_time_spine_pushdown_filter_application__plan0_optimized.sql
Show resolved
Hide resolved
courtneyholcomb
approved these changes
Jun 25, 2024
tlento
force-pushed
the
remove-pushdown-duplicated-where-constraints
branch
from
3c87606 to
981595e
Compare
tlento
force-pushed
the
add-sql-rendering-tests-for-pushdown-edge-cases
branch
from
fed6421 to
27328d4
Compare
tlento
force-pushed
the
remove-pushdown-duplicated-where-constraints
branch
from
981595e to
bb4eda4
Compare
Base automatically changed from
remove-pushdown-duplicated-where-constraints
to
main
June 26, 2024 00:44
The predicate pushdown optimizer tests cover direct edge cases for the optimizer alone, but we would like to have query rendering variations of this so we can see how optimizers interact in their query output. This adds the relevant query rendering test scenarios along with their associated snapshots.
tlento
force-pushed
the
add-sql-rendering-tests-for-pushdown-edge-cases
branch
from
27328d4 to
7975146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SQL rendering tests for pushdown edge cases
The predicate pushdown optimizer tests cover direct edge cases
for the optimizer alone, but we would like to have query rendering
variations of this so we can see how optimizers interact in their
query output.
This adds the relevant query rendering test scenarios along with
their associated snapshots.
Update SQL engine snapshots