Consolidate where constraint predicate pushdown management #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2024
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This was referenced Jun 25, 2024
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This was referenced Jun 25, 2024
This was referenced Jun 25, 2024
tlento
force-pushed
the
move-categorical-dimension-pushdown-to-optimizer
branch
from
3cbd865 to
cfc7833
Compare
Base automatically changed from
move-categorical-dimension-pushdown-to-optimizer
to
main
June 25, 2024 04:11
tlento
force-pushed
the
consolidate-where-constraint-pushdown-management
branch
from
4a07122 to
159e3e6
Compare
This was referenced Jun 25, 2024
courtneyholcomb
approved these changes
Jun 25, 2024
This was referenced Jun 25, 2024
Pushdown operations for where constraints were a bit scattered around due to the transition from build-time to optimize-time handling. This consolidates some of the mechanics. In particular, the where constraint pushdown state updates have been centralized into the PredicatePushdownState object, which allows for more streamlined updates at the callsites, and the where spec propagation has also been simplified to allow for all filter specs to be evaluated at once instead of splitting the evaluation between the WhereConstraintNode and input source node handlers.
tlento
force-pushed
the
consolidate-where-constraint-pushdown-management
branch
from
159e3e6 to
46517d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushdown operations for where constraints were a bit scattered
around due to the transition from build-time to optimize-time
handling. This consolidates some of the mechanics.
In particular, the where constraint pushdown state updates have
been centralized into the PredicatePushdownState object, which
allows for more streamlined updates at the callsites, and the
where spec propagation has also been simplified to allow for
all filter specs to be evaluated at once instead of splitting
the evaluation between the WhereConstraintNode and input source
node handlers.