-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for filters against various join types #1240
Merged
+85
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2024
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
added
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Jun 4, 2024
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
June 4, 2024 00:06 — with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
June 4, 2024 00:06 — with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
June 4, 2024 00:06 — with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
June 4, 2024 00:06 — with
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Jun 4, 2024
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
June 4, 2024 00:22 — with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
June 4, 2024 00:22 — with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
June 4, 2024 00:22 — with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
June 4, 2024 00:22 — with
GitHub Actions
Inactive
plypaul
approved these changes
Jun 4, 2024
tlento
force-pushed
the
enable-predicate-pushdown-for-categorical-dimension-filters
branch
from
June 12, 2024 00:00
7c2c34d
to
27e32dd
Compare
tlento
force-pushed
the
add-join-filter-itests
branch
from
June 12, 2024 00:01
c0a00c5
to
ff2748f
Compare
This was referenced Jun 12, 2024
tlento
force-pushed
the
enable-predicate-pushdown-for-categorical-dimension-filters
branch
from
June 25, 2024 03:11
27e32dd
to
8d08b8e
Compare
tlento
force-pushed
the
add-join-filter-itests
branch
from
June 25, 2024 03:12
ff2748f
to
8af1ba3
Compare
This was referenced Jun 25, 2024
tlento
force-pushed
the
enable-predicate-pushdown-for-categorical-dimension-filters
branch
from
June 25, 2024 03:30
8d08b8e
to
ca3043c
Compare
Base automatically changed from
enable-predicate-pushdown-for-categorical-dimension-filters
to
main
June 25, 2024 03:34
We currently have an incomplete set of integration tests for filters involving joins - our existing test only covers a filter against the joined in dimension, and then implicitly discards all null values. This change adds more robust coverage, including filters against our current range of supported dimension join types (FULL OUTER and LEFT OUTER) and joins allowing for NULL values on the tables that might return NULL due to a join miss. These tests help make some of the test coverage around predicate pushdown operations a bit more explicit, although they are not about pushdown specifically.
tlento
force-pushed
the
add-join-filter-itests
branch
from
June 25, 2024 03:35
8af1ba3
to
eec446c
Compare
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have an incomplete set of integration tests for filters
involving joins - our existing test only covers a filter against
the joined in dimension, and then implicitly discards all null values.
This change adds more robust coverage, including filters against
our current range of supported dimension join types (FULL OUTER and LEFT OUTER)
and joins allowing for NULL values on the tables that might return
NULL due to a join miss.
These tests help make some of the test coverage around predicate pushdown
operations a bit more explicit, although they are not about pushdown
specifically.