Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for filters against various join types #1240

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Jun 4, 2024

We currently have an incomplete set of integration tests for filters
involving joins - our existing test only covers a filter against
the joined in dimension, and then implicitly discards all null values.

This change adds more robust coverage, including filters against
our current range of supported dimension join types (FULL OUTER and LEFT OUTER)
and joins allowing for NULL values on the tables that might return
NULL due to a join miss.

These tests help make some of the test coverage around predicate pushdown
operations a bit more explicit, although they are not about pushdown
specifically.

Copy link
Contributor Author

tlento commented Jun 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlento and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Jun 4, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@tlento tlento added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jun 4, 2024
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS June 4, 2024 00:06 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS June 4, 2024 00:06 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS June 4, 2024 00:06 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS June 4, 2024 00:06 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jun 4, 2024
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS June 4, 2024 00:22 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS June 4, 2024 00:22 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS June 4, 2024 00:22 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS June 4, 2024 00:22 — with GitHub Actions Inactive
@tlento tlento requested review from plypaul and courtneyholcomb June 4, 2024 01:10
Copy link
Contributor Author

tlento commented Jun 25, 2024

Merge activity

  • Jun 24, 8:29 PM PDT: @tlento started a stack merge that includes this pull request via Graphite.
  • Jun 24, 8:35 PM PDT: Graphite rebased this pull request as part of a merge.
  • Jun 24, 8:39 PM PDT: @tlento merged this pull request with Graphite.

@tlento tlento force-pushed the enable-predicate-pushdown-for-categorical-dimension-filters branch from 8d08b8e to ca3043c Compare June 25, 2024 03:30
Base automatically changed from enable-predicate-pushdown-for-categorical-dimension-filters to main June 25, 2024 03:34
tlento added 2 commits June 25, 2024 03:35
We currently have an incomplete set of integration tests for filters
involving joins - our existing test only covers a filter against
the joined in dimension, and then implicitly discards all null values.

This change adds more robust coverage, including filters against
our current range of supported dimension join types (FULL OUTER and LEFT OUTER)
and joins allowing for NULL values on the tables that might return
NULL due to a join miss.

These tests help make some of the test coverage around predicate pushdown
operations a bit more explicit, although they are not about pushdown
specifically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants