-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify predicate pushdown state tracking #1301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2024
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This was referenced Jun 25, 2024
tlento
force-pushed
the
consolidate-where-constraint-pushdown-management
branch
from
June 25, 2024 05:21
4a07122
to
159e3e6
Compare
tlento
force-pushed
the
simplify-pushdown-state-tracking
branch
from
June 25, 2024 05:21
dc7ee4f
to
eaf6079
Compare
This was referenced Jun 25, 2024
courtneyholcomb
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 🧹
This was referenced Jun 25, 2024
tlento
force-pushed
the
consolidate-where-constraint-pushdown-management
branch
from
June 26, 2024 00:14
159e3e6
to
46517d0
Compare
tlento
force-pushed
the
simplify-pushdown-state-tracking
branch
from
June 26, 2024 00:14
eaf6079
to
11f049a
Compare
Base automatically changed from
consolidate-where-constraint-pushdown-management
to
main
June 26, 2024 00:24
The original implementation of the state tracker for predicate pushdown was built around an assumption that node-level and node-path access would be useful for propagating the application of filter predicates back up the dependency chain. After working towards an implementation of that logic it's clear that this is not particularly helpful. Although this tracking is theoretically useful for debugging scenarios the node-visit-level logging appears adequate, so we simplify our tracking before adding additional logic.
tlento
force-pushed
the
simplify-pushdown-state-tracking
branch
from
June 26, 2024 00:24
11f049a
to
677f26e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation of the state tracker for predicate pushdown
was built around an assumption that node-level and node-path access would
be useful for propagating the application of filter predicates back
up the dependency chain.
After working towards an implementation of that logic it's clear that this
is not particularly helpful. Although this tracking is theoretically useful
for debugging scenarios the node-visit-level logging appears adequate, so we
simplify our tracking before adding additional logic.