Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify predicate pushdown state tracking #1301

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Jun 25, 2024

The original implementation of the state tracker for predicate pushdown
was built around an assumption that node-level and node-path access would
be useful for propagating the application of filter predicates back
up the dependency chain.

After working towards an implementation of that logic it's clear that this
is not particularly helpful. Although this tracking is theoretically useful
for debugging scenarios the node-visit-level logging appears adequate, so we
simplify our tracking before adding additional logic.

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor Author

tlento commented Jun 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlento and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🧹

@tlento tlento force-pushed the consolidate-where-constraint-pushdown-management branch from 159e3e6 to 46517d0 Compare June 26, 2024 00:14
@tlento tlento force-pushed the simplify-pushdown-state-tracking branch from eaf6079 to 11f049a Compare June 26, 2024 00:14
Copy link
Contributor Author

tlento commented Jun 26, 2024

Merge activity

  • Jun 25, 5:24 PM PDT: @tlento started a stack merge that includes this pull request via Graphite.
  • Jun 25, 5:25 PM PDT: Graphite rebased this pull request as part of a merge.
  • Jun 25, 5:29 PM PDT: @tlento merged this pull request with Graphite.

Base automatically changed from consolidate-where-constraint-pushdown-management to main June 26, 2024 00:24
The original implementation of the state tracker for predicate pushdown
was built around an assumption that node-level and node-path access would
be useful for propagating the application of filter predicates back
up the dependency chain.

After working towards an implementation of that logic it's clear that this
is not particularly helpful. Although this tracking is theoretically useful
for debugging scenarios the node-visit-level logging appears adequate, so we
simplify our tracking before adding additional logic.
@tlento tlento force-pushed the simplify-pushdown-state-tracking branch from 11f049a to 677f26e Compare June 26, 2024 00:24
@tlento tlento merged commit c569eba into main Jun 26, 2024
15 checks passed
@tlento tlento deleted the simplify-pushdown-state-tracking branch June 26, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants