Store a list of input WhereFilterSpecs in the WhereConstraintNode #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This was referenced Jun 14, 2024
This was referenced Jun 14, 2024
tlento
force-pushed
the
06-11-enable_dataflowplanoptimizers_for_query_rendering_tests
branch
from
96006b6 to
d0346ab
Compare
tlento
force-pushed
the
consolidate-where-filter-merging
branch
from
02bc582 to
451ab0d
Compare
This was referenced Jun 25, 2024
tlento
force-pushed
the
06-11-enable_dataflowplanoptimizers_for_query_rendering_tests
branch
from
d0346ab to
7ea63ed
Compare
Base automatically changed from
06-11-enable_dataflowplanoptimizers_for_query_rendering_tests
to
main
June 25, 2024 03:47
Up until now we've been merging sets of WhereFilterSpec instances into a single instance and then storing that in the WhereConstraintNode. This made sense for rendering, but when trying to do predicate pushdown having the specs all merged together limits the space of filter pushdown opporunities. In order to allow for the same breadth of predicate pushdown opportunities we have at dataflow plan build time we keep the specs separate, and encapsulate the merging of these specs into the WhereConstraintNode itself.
tlento
force-pushed
the
consolidate-where-filter-merging
branch
from
451ab0d to
ad0298d
Compare
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now we've been merging sets of WhereFilterSpec instances
into a single instance and then storing that in the WhereConstraintNode.
This made sense for rendering, but when trying to do predicate pushdown
having the specs all merged together limits the space of filter pushdown
opporunities. In order to allow for the same breadth of predicate pushdown
opportunities we have at dataflow plan build time we keep the specs separate,
and encapsulate the merging of these specs into the WhereConstraintNode itself.