Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce order of application for DataflowPlanOptimizers #1307

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Jun 25, 2024

We want to make sure optimizers are run in the same order from
all outside callers, and a subsequent change will broaden our
exposure to dbt cloud service callers. Rather than expecting
everybody to pick the "right" optimization order, we simply
accept a set of optimizations to run and order them internally.

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor Author

tlento commented Jun 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlento and the rest of your teammates on Graphite Graphite

@tlento tlento force-pushed the enable-source-scan-optimizer-in-rendering-tests branch from 75ff8a2 to f66e1bb Compare June 26, 2024 00:15
@tlento tlento force-pushed the enforce-optimizer-ordering branch from 505a2e4 to 32707c0 Compare June 26, 2024 00:15
Copy link
Contributor Author

tlento commented Jun 26, 2024

Merge activity

  • Jun 25, 5:24 PM PDT: @tlento started a stack merge that includes this pull request via Graphite.
  • Jun 25, 5:54 PM PDT: Graphite rebased this pull request as part of a merge.
  • Jun 25, 5:58 PM PDT: @tlento merged this pull request with Graphite.

@tlento tlento force-pushed the enable-source-scan-optimizer-in-rendering-tests branch from f66e1bb to 61de816 Compare June 26, 2024 00:49
Base automatically changed from enable-source-scan-optimizer-in-rendering-tests to main June 26, 2024 00:53
We want to make sure optimizers are run in the same order from
all outside callers, and a subsequent change will broaden our
exposure to dbt cloud service callers. Rather than expecting
everybody to pick the "right" optimization order, we simply
accept a set of optimizations to run and order them internally.
@tlento tlento force-pushed the enforce-optimizer-ordering branch from 32707c0 to 80183f2 Compare June 26, 2024 00:54
@tlento tlento merged commit 1e97bf0 into main Jun 26, 2024
15 checks passed
@tlento tlento deleted the enforce-optimizer-ordering branch June 26, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants