-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce order of application for DataflowPlanOptimizers #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2024
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This was referenced Jun 25, 2024
This was referenced Jun 25, 2024
plypaul
approved these changes
Jun 25, 2024
tlento
force-pushed
the
enable-source-scan-optimizer-in-rendering-tests
branch
from
June 26, 2024 00:15
75ff8a2
to
f66e1bb
Compare
tlento
force-pushed
the
enforce-optimizer-ordering
branch
from
June 26, 2024 00:15
505a2e4
to
32707c0
Compare
tlento
force-pushed
the
enable-source-scan-optimizer-in-rendering-tests
branch
from
June 26, 2024 00:49
f66e1bb
to
61de816
Compare
Base automatically changed from
enable-source-scan-optimizer-in-rendering-tests
to
main
June 26, 2024 00:53
We want to make sure optimizers are run in the same order from all outside callers, and a subsequent change will broaden our exposure to dbt cloud service callers. Rather than expecting everybody to pick the "right" optimization order, we simply accept a set of optimizations to run and order them internally.
tlento
force-pushed
the
enforce-optimizer-ordering
branch
from
June 26, 2024 00:54
32707c0
to
80183f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure optimizers are run in the same order from
all outside callers, and a subsequent change will broaden our
exposure to dbt cloud service callers. Rather than expecting
everybody to pick the "right" optimization order, we simply
accept a set of optimizations to run and order them internally.