-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GkrOps for SIMD backend #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 6 files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7 and @spapinistarkware)
crates/prover/src/core/backend/simd/lookups/gkr.rs
line 21 at r3 (raw file):
Previously, shaharsamocha7 wrote…
what's DP?
Dynamic Programming
crates/prover/src/core/backend/simd/lookups/gkr.rs
line 22 at r3 (raw file):
Previously, shaharsamocha7 wrote…
y_initial is the last 4 elements in the vector, need another name IMO
or maybe comment that we pass on y in reverse order?
Initial in the sense that it's the y values that create the initial values for the algorithm but I see how It's confusing. Changed to y_last_chunk
. WDYT?
crates/prover/src/core/backend/simd/lookups/gkr.rs
line 70 at r3 (raw file):
Previously, shaharsamocha7 wrote…
Can you also add a test where
y.len() < LOG_N_LANES
?
Added
8ceac89
to
e175251
Compare
f19de9e
to
7188de2
Compare
e175251
to
c51f096
Compare
7188de2
to
4968f10
Compare
c51f096
to
d351947
Compare
4968f10
to
767cd08
Compare
d351947
to
ef6c4aa
Compare
767cd08
to
8de5550
Compare
ef6c4aa
to
89a31c7
Compare
8de5550
to
51c9107
Compare
89a31c7
to
6b5a7f9
Compare
51c9107
to
78201c2
Compare
6b5a7f9
to
cc39381
Compare
27886bf
to
4d47325
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r3, 2 of 3 files at r6, all commit messages.
Reviewable status: 5 of 6 files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7)
cc39381
to
967b6f3
Compare
4d47325
to
6cf72d3
Compare
967b6f3
to
78bd15b
Compare
6cf72d3
to
6f4cd6f
Compare
6f4cd6f
to
5d63696
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)
This change is