-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify FFT implementation for SIMD backend #596
Modify FFT implementation for SIMD backend #596
Conversation
89b71dc
to
05e275f
Compare
1c9274c
to
01ce893
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #596 +/- ##
==========================================
+ Coverage 91.98% 92.12% +0.13%
==========================================
Files 80 80
Lines 10916 11275 +359
Branches 10916 11275 +359
==========================================
+ Hits 10041 10387 +346
- Misses 806 821 +15
+ Partials 69 67 -2 ☔ View full report in Codecov by Sentry. |
05e275f
to
a5463cc
Compare
01ce893
to
ba78073
Compare
a5463cc
to
1c2de17
Compare
ba78073
to
0ff0d6e
Compare
1c2de17
to
6ffe5a9
Compare
0ff0d6e
to
d3c0c82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @andrewmilson)
a discussion (no related file):
It would be easier to check this Pr if you first add a commit that only copies the old files, so we can see in Reviewable just what changed.
6ffe5a9
to
948ab4d
Compare
d3c0c82
to
84a70a2
Compare
948ab4d
to
91c40c5
Compare
84a70a2
to
0123ac9
Compare
91c40c5
to
705a536
Compare
0123ac9
to
7fb3601
Compare
705a536
to
005b77b
Compare
7fb3601
to
1e963c5
Compare
b5a1cdc
to
1a083e5
Compare
347d446
to
df21476
Compare
1a083e5
to
8ec20f3
Compare
df21476
to
4979fb3
Compare
8ec20f3
to
2c1927c
Compare
941402f
to
0fdf4c7
Compare
2c1927c
to
f644aa6
Compare
0fdf4c7
to
d68543b
Compare
f644aa6
to
c88d1ef
Compare
d68543b
to
3cb07a8
Compare
c88d1ef
to
86625b8
Compare
3cb07a8
to
16f412d
Compare
86625b8
to
993fee6
Compare
83fd68d
to
1ade01d
Compare
993fee6
to
b09665e
Compare
1ade01d
to
42df366
Compare
b09665e
to
2d73436
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @andrewmilson)
crates/prover/src/core/backend/simd/fft/mod.rs
line 40 at r4 (raw file):
continue; } let val0 = load(values.add(i << 4).cast_const());
Consider inlining load() and store()
crates/prover/src/core/backend/simd/fft/rfft.rs
line 343 at r4 (raw file):
/// unreduced form, [0, P] including P. twiddle_dbl holds 16 values, each is a *double* of a twiddle /// factor, in unreduced form, [0, 2*P]. pub fn butterfly(
butterfly() is a generic function that exists already, I want to not confuse them
Suggestion:
simd_butterfly
2d73436
to
3b38213
Compare
This change is