-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CPU* structs to Cpu* to conform to Rust's naming convention #617
Rename CPU* structs to Cpu* to conform to Rust's naming convention #617
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #617 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 69 69
Lines 8995 8995
Branches 8995 8995
=======================================
Hits 8333 8333
Misses 590 590
Partials 72 72 ☔ View full report in Codecov by Sentry. |
2cd96f0
to
5f1e4f3
Compare
c8d3597
to
d1c03a4
Compare
9d234a8
to
3047e39
Compare
c58ed9a
to
97704cc
Compare
3047e39
to
5ffdadd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why clippy didn't yell about that?
Do we want to assert this naming convention?
Reviewed 37 of 37 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)
97704cc
to
c79fd8e
Compare
5ffdadd
to
d7f433c
Compare
c79fd8e
to
57d8803
Compare
d7f433c
to
21913db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)
57d8803
to
0c7a6e2
Compare
21913db
to
3ec8d07
Compare
0c7a6e2
to
5b0ba33
Compare
3ec8d07
to
fa4089a
Compare
5b0ba33
to
4415bcc
Compare
fa4089a
to
81c9507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 15 of 15 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)
4415bcc
to
50a6982
Compare
81c9507
to
1f8d0e0
Compare
This change is