-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eval order and interpolate to SecureEvaluation #794
Add eval order and interpolate to SecureEvaluation #794
Conversation
e8564ea
to
bbdf1cb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #794 +/- ##
==========================================
- Coverage 92.35% 92.26% -0.10%
==========================================
Files 91 91
Lines 12450 12442 -8
Branches 12450 12442 -8
==========================================
- Hits 11498 11479 -19
- Misses 846 857 +11
Partials 106 106 ☔ View full report in Codecov by Sentry. |
bbdf1cb
to
6815c93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
Cargo.lock
line 542 at r1 (raw file):
checksum = "49f1f14873335454500d59611f1cf4a4b0f786f9ac11f4312a78e4cf2566695b" [[package]]
Ran cargo update
hence changes here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @andrewmilson)
crates/prover/src/core/poly/circle/secure_poly.rs
line 61 at r2 (raw file):
/// evaluations. The evaluations are ordered according to the [CircleDomain] ordering. #[derive(Clone)] pub struct SecureEvaluation<B: FieldOps<BaseField>, EvalOrder> {
Consider adding a default value for EvalOredr=BitReversedOrder
441915c
to
4994125
Compare
6815c93
to
f54dc9f
Compare
f54dc9f
to
1f9784f
Compare
This change is