Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eval order and interpolate to SecureEvaluation #794

Merged

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Aug 20, 2024

This change is Reviewable

@andrewmilson andrewmilson force-pushed the 08-20-Add_eval_order_and_interpolate_to_SecureEvaluation branch from e8564ea to bbdf1cb Compare August 20, 2024 20:31
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 72.05882% with 19 lines in your changes missing coverage. Please review.

Project coverage is 92.26%. Comparing base (61e6c27) to head (1f9784f).

Files Patch % Lines
crates/prover/src/core/poly/circle/secure_poly.rs 30.76% 18 Missing ⚠️
crates/prover/src/core/pcs/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #794      +/-   ##
==========================================
- Coverage   92.35%   92.26%   -0.10%     
==========================================
  Files          91       91              
  Lines       12450    12442       -8     
  Branches    12450    12442       -8     
==========================================
- Hits        11498    11479      -19     
- Misses        846      857      +11     
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 08-20-Add_eval_order_and_interpolate_to_SecureEvaluation branch from bbdf1cb to 6815c93 Compare August 21, 2024 03:40
Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)


Cargo.lock line 542 at r1 (raw file):

checksum = "49f1f14873335454500d59611f1cf4a4b0f786f9ac11f4312a78e4cf2566695b"

[[package]]

Ran cargo update hence changes here.

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @andrewmilson)


crates/prover/src/core/poly/circle/secure_poly.rs line 61 at r2 (raw file):

/// evaluations. The evaluations are ordered according to the [CircleDomain] ordering.
#[derive(Clone)]
pub struct SecureEvaluation<B: FieldOps<BaseField>, EvalOrder> {

Consider adding a default value for EvalOredr=BitReversedOrder

Base automatically changed from push-opuzkmyqslno to dev August 21, 2024 16:05
@andrewmilson andrewmilson force-pushed the 08-20-Add_eval_order_and_interpolate_to_SecureEvaluation branch from 6815c93 to f54dc9f Compare August 21, 2024 16:06
@andrewmilson andrewmilson force-pushed the 08-20-Add_eval_order_and_interpolate_to_SecureEvaluation branch from f54dc9f to 1f9784f Compare August 21, 2024 16:24
@andrewmilson andrewmilson merged commit f976890 into dev Aug 21, 2024
15 of 16 checks passed
@andrewmilson andrewmilson deleted the 08-20-Add_eval_order_and_interpolate_to_SecureEvaluation branch August 21, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants