-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GKR implementation of Logup lookups #623
Add GKR implementation of Logup lookups #623
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #623 +/- ##
======================================
Coverage ? 92.84%
======================================
Files ? 82
Lines ? 10933
Branches ? 10933
======================================
Hits ? 10151
Misses ? 688
Partials ? 94 ☔ View full report in Codecov by Sentry. |
0aabbae
to
53e9d4e
Compare
789c3c9
to
9fbd265
Compare
53e9d4e
to
ccbe3b0
Compare
9fbd265
to
0cc0d79
Compare
ccbe3b0
to
1945331
Compare
0cc0d79
to
f8ff1d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 8 files at r3, 2 of 2 files at r5, 1 of 1 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)
crates/prover/src/core/backend/cpu/lookups/gkr.rs
line 180 at r8 (raw file):
) -> (SecureField, SecureField) { /// Represents the fraction `1 / x` struct Reciprocal {
I wonder if this is needed, or we can use Fraction with a constant numerator, and the compiler will optimizes with constant propagation...
Code quote:
struct Reciprocal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)
f8ff1d6
to
d846901
Compare
1945331
to
47caaef
Compare
d846901
to
c3cede8
Compare
47caaef
to
ed6103f
Compare
c3cede8
to
bdac672
Compare
ed6103f
to
d9935c0
Compare
aebb34a
to
2980f55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)
2980f55
to
35e313d
Compare
d9935c0
to
c137974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 10 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7 and @spapinistarkware)
crates/prover/src/core/backend/cpu/lookups/gkr.rs
line 180 at r8 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
I wonder if this is needed, or we can use Fraction with a constant numerator, and the compiler will optimizes with constant propagation...
Does not make the optimisation: https://godbolt.org/z/Mvz1YvdfT.
I remove this in a later PR in favour of a more general Reciprocal type (supporting regular and packed field types)
c137974
to
3da51dc
Compare
This change is