-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blake2s implementation for SIMD backend #601
Add blake2s implementation for SIMD backend #601
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #601 +/- ##
==========================================
- Coverage 91.36% 91.02% -0.34%
==========================================
Files 76 77 +1
Lines 9497 9807 +310
Branches 9497 9807 +310
==========================================
+ Hits 8677 8927 +250
- Misses 751 811 +60
Partials 69 69 ☔ View full report in Codecov by Sentry. |
e04a2f6
to
9ccaf1f
Compare
e84bf9a
to
962b3b7
Compare
9ccaf1f
to
c13b2e1
Compare
962b3b7
to
4c6a57e
Compare
c13b2e1
to
4265dcb
Compare
4c6a57e
to
436d936
Compare
4265dcb
to
b2f874d
Compare
436d936
to
64bba16
Compare
b2f874d
to
209d27b
Compare
64bba16
to
804fd02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: 64bba16 | Previous: 3d666a1 | Ratio |
---|---|---|---|
cpu bit_rev 24bit |
425012444 ns/iter (± 16504444 ) |
192851383 ns/iter (± 4615303 ) |
2.20 |
This comment was automatically generated by workflow using github-action-benchmark.
209d27b
to
71d3b5e
Compare
804fd02
to
1b6c6c1
Compare
71d3b5e
to
1a84c3c
Compare
1b6c6c1
to
fa27659
Compare
314685b
to
f50af06
Compare
9626fbb
to
4a7ffb2
Compare
f50af06
to
3b8ca2d
Compare
4a7ffb2
to
ccb0c2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @andrewmilson)
crates/prover/src/core/backend/simd/blake2s.rs
line 270 at r2 (raw file):
/// representing 16 packed instances of a message word. /// # Safety pub unsafe fn transpose_msgs(mut data: [u32x16; 16]) -> [u32x16; 16] {
rename
Suggestion:
pub unsafe fn transpose_states(mut data: [u32x16; 16]) -> [u32x16; 16] {
crates/prover/src/core/backend/simd/blake2s.rs
line 306 at r2 (raw file):
for _ in 0..3 { states = [ LoLoInterleaveHiLo::concat_swizzle(states[0], states[4]),
Fix as we discussed.
Code quote:
LoLoInterleaveHiLo::concat_swizzle(states[0], states[4]),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7)
crates/prover/src/core/backend/simd/blake2s.rs
line 270 at r2 (raw file):
Previously, shaharsamocha7 wrote…
rename
transpose_states is a different function
crates/prover/src/core/backend/simd/blake2s.rs
line 306 at r2 (raw file):
Previously, shaharsamocha7 wrote…
Fix as we discussed.
Is already updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7)
3b8ca2d
to
501b9ea
Compare
ccb0c2e
to
c693113
Compare
501b9ea
to
6e55592
Compare
c693113
to
120b1c5
Compare
6e55592
to
2719965
Compare
120b1c5
to
6182cfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @shaharsamocha7)
2719965
to
e4f0cbb
Compare
6182cfc
to
9f342e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @spapinistarkware)
This change is