-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert wide_fibbonacci AVX backend example to SIMD backend #615
Convert wide_fibbonacci AVX backend example to SIMD backend #615
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #615 +/- ##
==========================================
- Coverage 93.41% 93.06% -0.36%
==========================================
Files 84 84
Lines 11909 11909
Branches 11909 11909
==========================================
- Hits 11125 11083 -42
- Misses 702 744 +42
Partials 82 82 ☔ View full report in Codecov by Sentry. |
c67fd63
to
aceec97
Compare
e538634
to
d793297
Compare
f55de63
to
63ff9f4
Compare
9e6727f
to
5dd85bc
Compare
63ff9f4
to
813449a
Compare
5dd85bc
to
0d904e8
Compare
813449a
to
757b00f
Compare
0d904e8
to
af77ce3
Compare
757b00f
to
94e62ff
Compare
af77ce3
to
3377384
Compare
94e62ff
to
f5cf441
Compare
3377384
to
30ac630
Compare
f5cf441
to
ff7a173
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @andrewmilson)
a discussion (no related file):
Are the benchmarks as fast as our AVXBackend implementation?
30ac630
to
4631456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @alonh5)
a discussion (no related file):
Previously, alonh5 (Alon Haramati) wrote…
Are the benchmarks as fast as our AVXBackend implementation?
Yes https://starkware-libs.github.io/stwo/dev/bench/index.html
323a60a
to
0304a69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)
crates/prover/src/examples/wide_fibonacci/simd.rs
line 128 at r3 (raw file):
// RUST_LOG_SPAN_EVENTS=enter,close RUST_LOG=info RUST_BACKTRACE=1 RUSTFLAGS=" // -C target-cpu=native -C target-feature=+avx512f -C opt-level=2" cargo test // test_avx_wide_fib_prove -- --nocapture
Modify as well.
Code quote:
// Note: To see time measurement, run test with
// RUST_LOG_SPAN_EVENTS=enter,close RUST_LOG=info RUST_BACKTRACE=1 RUSTFLAGS="
// -C target-cpu=native -C target-feature=+avx512f -C opt-level=2" cargo test
// test_avx_wide_fib_prove -- --nocapture
0304a69
to
5c4b79c
Compare
This change is