Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): move papyrus_monitoring_gateway dep to root toml #275

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Aug 1, 2024

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Aug 1, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Aug 1, 2024

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.560 ms 34.972 ms 35.436 ms]
change: [+1.8224% +3.0564% +4.4358%] (p = 0.00 < 0.05)
Performance has regressed.
Found 14 outliers among 100 measurements (14.00%)
6 (6.00%) high mild
8 (8.00%) high severe

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (d9375b9) to head (68fdc04).

Additional details and impacted files
@@                                   Coverage Diff                                   @@
##           08-01-chore_ci_move_papyrus_consensus_dep_to_root_toml     #275   +/-   ##
=======================================================================================
  Coverage                                                   76.48%   76.48%           
=======================================================================================
  Files                                                         310      310           
  Lines                                                       34098    34098           
  Branches                                                    34098    34098           
=======================================================================================
  Hits                                                        26081    26081           
  Misses                                                       5751     5751           
  Partials                                                     2266     2266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review August 4, 2024 16:08
@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_papyrus_consensus_dep_to_root_toml branch from d9375b9 to 2f3a299 Compare August 5, 2024 07:28
@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_papyrus_monitoring_gateway_dep_to_root_toml branch from 68fdc04 to 5feecba Compare August 5, 2024 07:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants