Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): move starknet_mempool dep to root toml #264

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Aug 1, 2024

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Aug 1, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (08-01-chore_ci_move_starknet_sierra_compile_dep_to_root_toml@3487973). Learn more about missing BASE report.

Additional details and impacted files
@@                                       Coverage Diff                                       @@
##             08-01-chore_ci_move_starknet_sierra_compile_dep_to_root_toml     #264   +/-   ##
===============================================================================================
  Coverage                                                                ?   76.48%           
===============================================================================================
  Files                                                                   ?      310           
  Lines                                                                   ?    34098           
  Branches                                                                ?    34098           
===============================================================================================
  Hits                                                                    ?    26081           
  Misses                                                                  ?     5751           
  Partials                                                                ?     2266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review August 4, 2024 16:07
@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_starknet_sierra_compile_dep_to_root_toml branch from 22d8244 to 3487973 Compare August 5, 2024 07:22
@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_starknet_mempool_dep_to_root_toml branch from c9a4cb5 to 6ee8091 Compare August 5, 2024 07:22
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants