Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): move papyrus_test_utils dep to root toml #271

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Aug 1, 2024

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Aug 1, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.49%. Comparing base (03e6e51) to head (985c48c).

Additional details and impacted files
@@                                  Coverage Diff                                  @@
##           08-01-chore_ci_move_starknet_client_dep_to_root_toml     #271   +/-   ##
=====================================================================================
  Coverage                                                 76.48%   76.49%           
=====================================================================================
  Files                                                       310      310           
  Lines                                                     34098    34098           
  Branches                                                  34098    34098           
=====================================================================================
+ Hits                                                      26081    26082    +1     
  Misses                                                     5751     5751           
+ Partials                                                   2266     2265    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review August 4, 2024 16:07
@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_starknet_client_dep_to_root_toml branch from 03e6e51 to 672b151 Compare August 5, 2024 07:26
@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_papyrus_test_utils_dep_to_root_toml branch from 985c48c to 0435ac5 Compare August 5, 2024 07:26
Copy link

github-actions bot commented Aug 5, 2024

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.531 ms 35.119 ms 35.827 ms]
change: [+1.2137% +3.0289% +5.2054%] (p = 0.00 < 0.05)
Performance has regressed.
Found 23 outliers among 100 measurements (23.00%)
5 (5.00%) high mild
18 (18.00%) high severe

@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants