-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): move committer dep to root toml #265
chore(ci): move committer dep to root toml #265
Conversation
3250db8
to
c9a4cb5
Compare
4c29466
to
629ad81
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 08-01-chore_ci_move_starknet_mempool_dep_to_root_toml #265 +/- ##
======================================================================================
Coverage 76.48% 76.48%
======================================================================================
Files 310 310
Lines 34098 34098
Branches 34098 34098
======================================================================================
Hits 26081 26081
Misses 5751 5751
Partials 2266 2266 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please explain why?
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of multiple, identical, dependencies of the form { path = "../X", version = "Y" }
, all dependencies will be workspace = true
and the path + version will be set once.
this will make it easier to manage release branches: if we want all dependencies between crates to be for published versions (no paths), for example, this will be much easier to achieve when the dependency is only declared in the root cargo toml
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
c9a4cb5
to
6ee8091
Compare
629ad81
to
14aa0ea
Compare
Benchmark movements: |
This change is