Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): move blockifier dep to root toml #256

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Aug 1, 2024

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Aug 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite Graphite

This was referenced Aug 1, 2024
@dorimedini-starkware dorimedini-starkware self-assigned this Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (957f942) to head (c002cc1).

Additional details and impacted files
@@                                 Coverage Diff                                  @@
##           08-01-chore_ci_move_papyrus_config_dep_to_root_toml     #256   +/-   ##
====================================================================================
  Coverage                                                76.48%   76.48%           
====================================================================================
  Files                                                      310      310           
  Lines                                                    34098    34098           
  Branches                                                 34098    34098           
====================================================================================
  Hits                                                     26081    26081           
  Misses                                                    5751     5751           
  Partials                                                  2266     2266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_papyrus_config_dep_to_root_toml branch from 20ad53b to 957f942 Compare August 1, 2024 12:29
@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_blockifier_dep_to_root_toml branch from bad7cdf to c002cc1 Compare August 1, 2024 12:29
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review August 4, 2024 16:06
@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_blockifier_dep_to_root_toml branch from c002cc1 to cfb79a7 Compare August 5, 2024 07:18
@graphite-app graphite-app bot changed the base branch from 08-01-chore_ci_move_papyrus_config_dep_to_root_toml to main-v0.13.2 August 5, 2024 07:18
Copy link

github-actions bot commented Aug 5, 2024

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [29.459 ms 29.503 ms 29.549 ms]
change: [+1.1547% +1.6699% +2.0763%] (p = 0.00 < 0.05)
Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild

@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants