Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): move papyrus_rpc dep to root toml #258

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Aug 1, 2024

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Aug 1, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite Graphite

This was referenced Aug 1, 2024
@dorimedini-starkware dorimedini-starkware self-assigned this Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (d212c72) to head (73d1a4e).

Additional details and impacted files
@@                                     Coverage Diff                                     @@
##           08-01-chore_ci_move_mempool_test_utils_dep_to_root_toml     #258      +/-   ##
===========================================================================================
- Coverage                                                    76.49%   76.48%   -0.01%     
===========================================================================================
  Files                                                          310      310              
  Lines                                                        34098    34098              
  Branches                                                     34098    34098              
===========================================================================================
- Hits                                                         26082    26081       -1     
  Misses                                                        5751     5751              
- Partials                                                      2265     2266       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_mempool_test_utils_dep_to_root_toml branch from c37180d to e5260dd Compare August 1, 2024 12:29
@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_papyrus_rpc_dep_to_root_toml branch from 11faa76 to 8220b75 Compare August 1, 2024 12:29
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review August 4, 2024 16:06
@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_mempool_test_utils_dep_to_root_toml branch from e5260dd to d212c72 Compare August 5, 2024 07:18
@dorimedini-starkware dorimedini-starkware force-pushed the 08-01-chore_ci_move_papyrus_rpc_dep_to_root_toml branch from 8220b75 to 73d1a4e Compare August 5, 2024 07:19
Copy link

github-actions bot commented Aug 5, 2024

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [29.253 ms 29.333 ms 29.436 ms]
change: [+1.6015% +2.1076% +2.6338%] (p = 0.00 < 0.05)
Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) low severe
4 (4.00%) high mild
2 (2.00%) high severe

@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants