-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(search): match geographic entities in search #3388
Merged
marcelgerber
merged 9 commits into
search-feature-branch-2024-2
from
algolia-geographic-entities
Apr 16, 2024
Merged
feat(search): match geographic entities in search #3388
marcelgerber
merged 9 commits into
search-feature-branch-2024-2
from
algolia-geographic-entities
Apr 16, 2024
+167
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
from
March 25, 2024 12:34
d45c394
to
ab1d6c2
Compare
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
2 times, most recently
from
March 26, 2024 08:00
a3c1ac9
to
d0cd95b
Compare
5 tasks
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
2 times, most recently
from
March 27, 2024 14:02
7e31f37
to
d0d5c6a
Compare
This was referenced Mar 27, 2024
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
from
March 27, 2024 23:29
d0d5c6a
to
aae51b7
Compare
marcelgerber
changed the base branch from
master
to
available-entities-accurate
March 27, 2024 23:29
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @marcelgerber and the rest of your teammates on Graphite |
marcelgerber
force-pushed
the
available-entities-accurate
branch
from
March 28, 2024 13:42
9fa5f53
to
75f90b7
Compare
marcelgerber
changed the base branch from
available-entities-accurate
to
available-entities-indexing
March 28, 2024 14:17
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
from
March 28, 2024 14:17
aae51b7
to
ce7b3e8
Compare
marcelgerber
changed the base branch from
available-entities-indexing
to
remove-available-entities-config
March 28, 2024 14:18
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
from
March 28, 2024 14:18
ce7b3e8
to
1e9bfd8
Compare
marcelgerber
force-pushed
the
remove-available-entities-config
branch
from
March 29, 2024 08:13
cf502dd
to
240aa18
Compare
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
from
March 29, 2024 08:13
1e9bfd8
to
d5845ab
Compare
marcelgerber
force-pushed
the
remove-available-entities-config
branch
from
March 29, 2024 09:52
240aa18
to
c49358e
Compare
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
from
March 29, 2024 09:52
d5845ab
to
0ef4ae7
Compare
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
from
April 10, 2024 14:55
0ef4ae7
to
5aa3cd9
Compare
// Remove any parenthetical content from _the end_ of a string | ||
// E.g. "Africa (UN)" -> "Africa" | ||
export function removeTrailingParenthetical(str: string): string { | ||
return str.replace(/\s*\(.*\)$/, "") |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
This [regular expression](1) that depends on [library input](2) may run slow on strings with many repetitions of ' '.
This [regular expression](3) that depends on [library input](2) may run slow on strings starting with '(' and with many repetitions of '('.
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
from
April 11, 2024 15:33
9f0d235
to
1e783f8
Compare
This was referenced Apr 11, 2024
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
from
April 11, 2024 16:22
1e783f8
to
d9e4bba
Compare
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
from
April 15, 2024 13:52
d9e4bba
to
6424fce
Compare
marcelgerber
changed the base branch from
master
to
search-feature-branch-2024-2
April 16, 2024 06:54
…synonyms can work
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
from
April 16, 2024 07:08
cb9cd51
to
1f70486
Compare
marcelgerber
merged commit Apr 16, 2024
7f88da5
into
search-feature-branch-2024-2
14 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3330.
TODOs:
Life expectancy India Nigeria
to the placeholder textavailableEntityNames
for Algolia:EntitySelectionMode.Disabled
[population by world region Laos
]tableForSelection
[example chart,meat production by type argentina
]charts_x_entities
table #3418 & feat(algolia): usecharts_x_entities
table for Algolia indexing #3424salmon (farmed)
Korea (former)
forSouth Korea
[regime polity south korea
]life expectancy uae
sex ratio uk
/thumbnail
URL to.env
fileEntity indexing: Why doesaccess-to-clean-fuels-and-technologies-for-cooking
supposedly have data for "Low-income countries", even though it hasn't?