feat(search): disable fulltext pages search if we detect a country name in query
#3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @marcelgerber and the rest of your teammates on |
This was referenced Apr 11, 2024
marcelgerber
force-pushed
the
search-pages-disable-fulltext-country-detection
branch
from
cb9fc63 to
67583c5
Compare
marcelgerber
force-pushed
the
search-pages-disable-fulltext-country-detection
branch
2 times, most recently
from
f54369b to
c1520b0
Compare
marcelgerber
force-pushed
the
search-pages-disable-fulltext-country-detection
branch
from
c1520b0 to
f9eb694
Compare
ikesau
approved these changes
Apr 15, 2024
marcelgerber
deleted the
search-pages-disable-fulltext-country-detection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joe was suggesting this; because otherwise the R&W results are pretty much useless when a country name is present in the query (which we are gonna be promoting now).
Overall, we were also talking about how useless fulltext queries usually are. There are only some rare cases where they provide any value currently; and if we end up in a situation where we also index headings, key insights, SDG targets etc., then we could stop doing fulltext search entirely.
Tip: Review with whitespace changes hidden :)