Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove $.data.availableEntities from configs and schema #3419

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Mar 27, 2024

Follow-up work to #3418.

Drops the $.data property from all our configs. It was only used for $.data.availableEntities, which we won't need any longer.

@marcelgerber marcelgerber changed the title chore(schema): new schema version, remove data.availableEntities chore: remove $.data.availableEntities from configs, schema Mar 27, 2024
@marcelgerber marcelgerber marked this pull request as ready for review March 27, 2024 23:11
@marcelgerber marcelgerber changed the title chore: remove $.data.availableEntities from configs, schema chore: remove $.data.availableEntities from configs and schema Mar 27, 2024
@marcelgerber marcelgerber force-pushed the available-entities-accurate branch from 22cb557 to 2d899e8 Compare March 27, 2024 23:29
@marcelgerber marcelgerber force-pushed the remove-available-entities-config branch from 1d8f6ee to 0437e81 Compare March 27, 2024 23:29
@marcelgerber marcelgerber changed the base branch from available-entities-accurate to algolia-geographic-entities March 27, 2024 23:29
@marcelgerber marcelgerber force-pushed the algolia-geographic-entities branch from aae51b7 to ce7b3e8 Compare March 28, 2024 14:17
@marcelgerber marcelgerber force-pushed the remove-available-entities-config branch from 0437e81 to 2464ba4 Compare March 28, 2024 14:17
@marcelgerber marcelgerber changed the base branch from algolia-geographic-entities to available-entities-indexing March 28, 2024 14:18
@marcelgerber marcelgerber force-pushed the remove-available-entities-config branch from 2464ba4 to cf502dd Compare March 28, 2024 14:18
@marcelgerber marcelgerber requested a review from danyx23 March 28, 2024 14:18
@marcelgerber marcelgerber force-pushed the available-entities-indexing branch from 3a51b63 to d739f27 Compare March 29, 2024 08:12
@marcelgerber marcelgerber force-pushed the remove-available-entities-config branch from cf502dd to 240aa18 Compare March 29, 2024 08:13
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there is a small issue with a sql comment that breaks the migration. Once this is fixed it's good to go.

@marcelgerber marcelgerber force-pushed the remove-available-entities-config branch from 240aa18 to c49358e Compare March 29, 2024 09:52
Base automatically changed from available-entities-indexing to master April 8, 2024 10:31
@marcelgerber marcelgerber merged commit 3531a62 into master Apr 8, 2024
19 checks passed
@marcelgerber marcelgerber deleted the remove-available-entities-config branch April 8, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants