-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove $.data.availableEntities
from configs and schema
#3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @marcelgerber and the rest of your teammates on Graphite |
4 tasks
marcelgerber
changed the title
chore(schema): new schema version, remove
chore: remove Mar 27, 2024
data.availableEntities
$.data.availableEntities
from configs, schema
marcelgerber
changed the title
chore: remove
chore: remove Mar 27, 2024
$.data.availableEntities
from configs, schema$.data.availableEntities
from configs and schema
marcelgerber
force-pushed
the
available-entities-accurate
branch
from
March 27, 2024 23:29
22cb557
to
2d899e8
Compare
marcelgerber
force-pushed
the
remove-available-entities-config
branch
from
March 27, 2024 23:29
1d8f6ee
to
0437e81
Compare
marcelgerber
changed the base branch from
available-entities-accurate
to
algolia-geographic-entities
March 27, 2024 23:29
18 tasks
marcelgerber
force-pushed
the
algolia-geographic-entities
branch
from
March 28, 2024 14:17
aae51b7
to
ce7b3e8
Compare
marcelgerber
force-pushed
the
remove-available-entities-config
branch
from
March 28, 2024 14:17
0437e81
to
2464ba4
Compare
marcelgerber
changed the base branch from
algolia-geographic-entities
to
available-entities-indexing
March 28, 2024 14:18
marcelgerber
force-pushed
the
remove-available-entities-config
branch
from
March 28, 2024 14:18
2464ba4
to
cf502dd
Compare
marcelgerber
force-pushed
the
available-entities-indexing
branch
from
March 29, 2024 08:12
3a51b63
to
d739f27
Compare
marcelgerber
force-pushed
the
remove-available-entities-config
branch
from
March 29, 2024 08:13
cf502dd
to
240aa18
Compare
danyx23
reviewed
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but there is a small issue with a sql comment that breaks the migration. Once this is fixed it's good to go.
db/migration/1711580214803-RemoveAvailableEntitiesFromChartConfigs.ts
Outdated
Show resolved
Hide resolved
marcelgerber
force-pushed
the
remove-available-entities-config
branch
from
March 29, 2024 09:52
240aa18
to
c49358e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up work to #3418.
Drops the
$.data
property from all our configs. It was only used for$.data.availableEntities
, which we won't need any longer.