Explorer search: Incorporate design feedback #3493
Merged
+142
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @marcelgerber and the rest of your teammates on |
marcelgerber
force-pushed
the
search-explorer-design-fixes
branch
from
c6e6b12 to
1457e36
Compare
marcelgerber
changed the title
ikesau
approved these changes
Apr 15, 2024
| @@ -316,7 +318,11 @@ function ExplorerHit({ | |||
| highlightedTagName="strong" | |||
| className="search-results__explorer-view-title" | |||
| /> | |||
| <FontAwesomeIcon icon={faArrowRight} /> | |||
| <span className="nowrap icon-container"> | |||
| ‍ | |||
marcelgerber
force-pushed
the
remove-legacy-explorer-indexing
branch
from
8e23762 to
e782a7f
Compare
Base automatically changed from
remove-legacy-explorer-indexing
to
search-feature-branch-2024-2
April 16, 2024 07:02
iOS Safari was using some grey as its default
marcelgerber
force-pushed
the
search-explorer-design-fixes
branch
from
dbe23ac to
3d152a7
Compare
marcelgerber
merged commit f7e23da
into
search-feature-branch-2024-2
14 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.