Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): pre-select explorer entities if they appear in search query #3483

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Apr 11, 2024

Once we detect a country/region name in the search query string, we now add it as a query param to the explorer link.
We do this even though we don't know for sure that data for this country will be available in the explorer. This is an accepted tradeoff, since we believe that it'll be worth it for the 80-90% of cases where this just works (most of our explorers have countries as entities, and most of them include a lot of different entities).
And then, if no data is available for that entity, then the user will be presented with an empty explorer - which is not great, but also not the end of the world.

@marcelgerber marcelgerber force-pushed the search-explorer-indexing-algolia branch from 4927798 to ca8196c Compare April 11, 2024 16:22
@marcelgerber marcelgerber force-pushed the search-explorer-indexing-country-selection branch from e50fd96 to a001832 Compare April 11, 2024 16:22
@marcelgerber marcelgerber requested a review from ikesau April 11, 2024 16:33
@marcelgerber marcelgerber marked this pull request as ready for review April 11, 2024 16:33
@marcelgerber marcelgerber force-pushed the search-explorer-indexing-algolia branch from ca8196c to d46ddf7 Compare April 15, 2024 10:14
@marcelgerber marcelgerber force-pushed the search-explorer-indexing-country-selection branch from a001832 to f0346a3 Compare April 15, 2024 10:14
@marcelgerber marcelgerber force-pushed the search-explorer-indexing-algolia branch from d46ddf7 to d9dc7b2 Compare April 15, 2024 11:21
@marcelgerber marcelgerber force-pushed the search-explorer-indexing-country-selection branch from f0346a3 to 2c22607 Compare April 15, 2024 11:21
Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🙂

Base automatically changed from search-explorer-indexing-algolia to search-feature-branch-2024-2 April 16, 2024 06:56
@marcelgerber marcelgerber force-pushed the search-explorer-indexing-country-selection branch from 2c22607 to 8d6c5c0 Compare April 16, 2024 07:00
@marcelgerber marcelgerber merged commit c5f3491 into search-feature-branch-2024-2 Apr 16, 2024
14 of 15 checks passed
@marcelgerber marcelgerber deleted the search-explorer-indexing-country-selection branch April 16, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants