-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(search): pre-select explorer entities if they appear in search query #3483
Merged
marcelgerber
merged 1 commit into
search-feature-branch-2024-2
from
search-explorer-indexing-country-selection
Apr 16, 2024
Merged
feat(search): pre-select explorer entities if they appear in search query #3483
marcelgerber
merged 1 commit into
search-feature-branch-2024-2
from
search-explorer-indexing-country-selection
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @marcelgerber and the rest of your teammates on Graphite |
marcelgerber
force-pushed
the
search-explorer-indexing-algolia
branch
from
April 11, 2024 16:22
4927798
to
ca8196c
Compare
marcelgerber
force-pushed
the
search-explorer-indexing-country-selection
branch
from
April 11, 2024 16:22
e50fd96
to
a001832
Compare
This was referenced Apr 11, 2024
marcelgerber
force-pushed
the
search-explorer-indexing-algolia
branch
from
April 15, 2024 10:14
ca8196c
to
d46ddf7
Compare
marcelgerber
force-pushed
the
search-explorer-indexing-country-selection
branch
from
April 15, 2024 10:14
a001832
to
f0346a3
Compare
marcelgerber
force-pushed
the
search-explorer-indexing-algolia
branch
from
April 15, 2024 11:21
d46ddf7
to
d9dc7b2
Compare
marcelgerber
force-pushed
the
search-explorer-indexing-country-selection
branch
from
April 15, 2024 11:21
f0346a3
to
2c22607
Compare
ikesau
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 🙂
Base automatically changed from
search-explorer-indexing-algolia
to
search-feature-branch-2024-2
April 16, 2024 06:56
marcelgerber
force-pushed
the
search-explorer-indexing-country-selection
branch
from
April 16, 2024 07:00
2c22607
to
8d6c5c0
Compare
marcelgerber
merged commit Apr 16, 2024
c5f3491
into
search-feature-branch-2024-2
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we detect a country/region name in the search query string, we now add it as a query param to the explorer link.
We do this even though we don't know for sure that data for this country will be available in the explorer. This is an accepted tradeoff, since we believe that it'll be worth it for the 80-90% of cases where this just works (most of our explorers have countries as entities, and most of them include a lot of different entities).
And then, if no data is available for that entity, then the user will be presented with an empty explorer - which is not great, but also not the end of the world.