Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(algolia): use charts_x_entities table for Algolia indexing #3424

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Mar 28, 2024

Review hints: Please have a look at the query :)

Especially make sure that there's not gonna be duplicate entries in the tags and entityNames arrays.

@marcelgerber marcelgerber requested a review from danyx23 March 28, 2024 14:10
@marcelgerber marcelgerber marked this pull request as ready for review March 28, 2024 14:10
Base automatically changed from available-entities-accurate to master March 28, 2024 14:19
@marcelgerber marcelgerber force-pushed the available-entities-indexing branch from 3a51b63 to d739f27 Compare March 29, 2024 08:12
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but did you check if the upstream code takes care of null values in keyChartForTags? Maybe it's better to check this in the function directly?

@marcelgerber marcelgerber merged commit 404feaf into master Apr 8, 2024
32 checks passed
@marcelgerber marcelgerber deleted the available-entities-indexing branch April 8, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants