Data pages: improve citations #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2023
Merged
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
danyx23
force-pushed
the
10-18-data-page-better-slugify
branch
from
6473480 to
0f4d04b
Compare
danyx23
force-pushed
the
10-19-data-page-better-citations
branch
from
c215f61 to
8aa1fda
Compare
danyx23
force-pushed
the
10-18-data-page-better-slugify
branch
from
0f4d04b to
90e1f18
Compare
danyx23
force-pushed
the
10-19-data-page-better-citations
branch
from
8aa1fda to
2d3c7ac
Compare
danyx23
force-pushed
the
10-18-data-page-better-slugify
branch
from
90e1f18 to
66b41aa
Compare
danyx23
force-pushed
the
10-19-data-page-better-citations
branch
from
2d3c7ac to
5eddef5
Compare
danyx23
force-pushed
the
10-18-data-page-better-slugify
branch
from
66b41aa to
15c5b28
Compare
danyx23
force-pushed
the
10-19-data-page-better-citations
branch
from
5eddef5 to
9b54071
Compare
danyx23
force-pushed
the
10-18-data-page-better-slugify
branch
from
15c5b28 to
889873e
Compare
danyx23
force-pushed
the
10-19-data-page-better-citations
branch
from
9b54071 to
71e9dba
Compare
danyx23
force-pushed
the
10-19-data-page-better-citations
branch
from
9d26027 to
05ec5fa
Compare
This was referenced Oct 24, 2023
sophiamersmann
approved these changes
Oct 24, 2023
| datapageData.origins[0].urlDownload | ||
| const citationLong = `${citationShort}. ${datapageData.title}. ${originsLong}, ${processedAdapted} by Our World In Data. Retrieved ${dateAccessed} from ${urlAccessed}` | ||
| const citationShort = `${attributionPotentiallyShortened} – with ${processedAdapted} by Our World In Data (${yearOfUpdate})` | ||
| const citationLonger = `${attributionPotentiallyShortened} – with ${processedAdapted} by Our World In Data (${yearOfUpdate})` |
There was a problem hiding this comment.
Are citationShort and citationLonger supposed to be the same?
There was a problem hiding this comment.
Ah good catch, thanks! I fixed this in a later Pr where I already have an intermediate variable that is useful for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls how we do citations on datapages. Max and Joe came up with a new way for how to cite data pages themselves (the last thing in the citation section) that needs the citation information of the related topic page.
There are also various minor improvements to the display of sources/origins.
This is related to #2755 and fixes these points: