Show only important sources in summaries

[danyx23]

This PR introduces two different ways to iterate over the sources of a chart - a columnsWithSourcesExtensive and columnsWithSourcesCondensed. When rendering the sources at the bottom of the chart we want to only show the most relevant ones (i.e. hide stuff like population used for sizing a scatter) - for this we use the Condensed version. When showing the sources tab we use the Extensive so that all our sources are rendered there.

This is related to #2755 and fixes these points:

• Following Ed's suggested (it seems we already decided about it at some other time in the past) scatter plots should not show population in the footer of the chart, but they should show population in the sources tab (in "Data published by").

[danyx23]

Current dependencies on/for this PR:

• master
  • PR misc-allow-tmux-shell-override #2786
    • PR Show only important sources in summaries #2798 👈
      • PR Fix datapage headings #2799
        • PR Better key info block #2800
          • PR Better date displays - processing level display #2801
            • PR Better automatic links to topic pages #2802
              • PR Data pages: improve citations #2806
                • PR Data pages: Extract data page component IndicatorBrief #2839
                  • PR Data pages: extract shared component for sources #2840
                  • PR Data pages: extract shared component IndicatorProcessing #2841
                • PR Data pages: Update citations #2834

This comment was auto-generated by Graphite.

[sophiamersmann]

Looks good to me!

Nit: Maybe it would be nice to always specify columns in the same order? (probably the order you're using for the extended list of source columns)

[danyx23]

Merge activity

• Oct 24, 12:28 PM: @danyx23 merged this pull request with Graphite.