Better automatic links to topic pages #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2023
Merged
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
6 tasks
danyx23
force-pushed
the
10-18-data-page-better-date-formats-processing-level
branch
from
e69d088 to
1f47473
Compare
danyx23
force-pushed
the
10-18-data-page-better-slugify
branch
from
6473480 to
0f4d04b
Compare
danyx23
force-pushed
the
10-18-data-page-better-date-formats-processing-level
branch
from
1f47473 to
5e477cc
Compare
danyx23
force-pushed
the
10-18-data-page-better-slugify
branch
from
0f4d04b to
90e1f18
Compare
danyx23
force-pushed
the
10-18-data-page-better-date-formats-processing-level
branch
from
5e477cc to
2b3b150
Compare
danyx23
force-pushed
the
10-18-data-page-better-slugify
branch
from
90e1f18 to
66b41aa
Compare
danyx23
force-pushed
the
10-18-data-page-better-date-formats-processing-level
branch
from
2b3b150 to
c6be603
Compare
danyx23
force-pushed
the
10-18-data-page-better-slugify
branch
from
66b41aa to
15c5b28
Compare
danyx23
force-pushed
the
10-18-data-page-better-date-formats-processing-level
branch
from
c6be603 to
a2623bc
Compare
danyx23
force-pushed
the
10-18-data-page-better-slugify
branch
from
15c5b28 to
889873e
Compare
danyx23
changed the title
sophiamersmann
approved these changes
Oct 23, 2023
This was referenced Oct 24, 2023
Base automatically changed from
10-18-data-page-better-date-formats-processing-level
to
master
October 24, 2023 16:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the right top of topic pages we show tags if they are given in the ETL. The tags are rendered as little pills and should link to the topic page that we have for this tag. Unfortunately, at this point we don't have the "authoritative links" stored with the tags and no association between tags and their topic pages so we slugify the text and 🤞.
This PR improves the slugify function for this particular use case. It's not bullet proof but it makes sure that the system works for a few more of the important tags. Some remain broken until we store the links properly.