Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better key info block #2800

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Better key info block #2800

merged 2 commits into from
Oct 24, 2023

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Oct 19, 2023

This Pr is a stop gap measure until we have the proper redesigns of the "indicator flashcard" section below the chart that better deals with missing texts. What happens here is that the descriptionShort is always shown if present, the descriptionKey is shown as a list and a bug with the "go to FAQ" button is fixed

This is related to #2755 and fixes these points:

  • The heading of the text section "What you should know about this data" should change to something less strong when showing something other than the description_key field and be hidden if we have no text.
  • Bullet points from description_key are not picked.

@danyx23 danyx23 force-pushed the 10-17-data-page-headings-fixes branch from 04e0c8e to e35ee40 Compare October 23, 2023 08:12
@danyx23 danyx23 force-pushed the 10-17-data-page-key-info branch from f76f08d to 141f81c Compare October 23, 2023 08:12
@danyx23 danyx23 changed the title data-page-key-info Better key info block Oct 23, 2023
@danyx23 danyx23 marked this pull request as ready for review October 23, 2023 08:38
Base automatically changed from 10-17-data-page-headings-fixes to master October 24, 2023 16:29
@danyx23 danyx23 merged commit fe959a3 into master Oct 24, 2023
13 checks passed
@danyx23 danyx23 deleted the 10-17-data-page-key-info branch October 24, 2023 16:29
Copy link
Contributor Author

danyx23 commented Oct 24, 2023

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants