-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better date displays - processing level display #2801
Merged
danyx23
merged 1 commit into
master
from
10-18-data-page-better-date-formats-processing-level
Oct 24, 2023
Merged
Better date displays - processing level display #2801
danyx23
merged 1 commit into
master
from
10-18-data-page-better-date-formats-processing-level
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2023
Merged
Merged
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
danyx23
force-pushed
the
10-17-data-page-key-info
branch
from
October 20, 2023 13:49
ee2568e
to
5aaa83c
Compare
danyx23
force-pushed
the
10-18-data-page-better-date-formats-processing-level
branch
from
October 20, 2023 13:49
e69d088
to
1f47473
Compare
danyx23
force-pushed
the
10-17-data-page-key-info
branch
from
October 23, 2023 08:08
5aaa83c
to
f76f08d
Compare
danyx23
force-pushed
the
10-18-data-page-better-date-formats-processing-level
branch
from
October 23, 2023 08:08
1f47473
to
5e477cc
Compare
danyx23
force-pushed
the
10-17-data-page-key-info
branch
from
October 23, 2023 08:12
f76f08d
to
141f81c
Compare
danyx23
force-pushed
the
10-18-data-page-better-date-formats-processing-level
branch
2 times, most recently
from
October 23, 2023 08:35
2b3b150
to
c6be603
Compare
danyx23
force-pushed
the
10-18-data-page-better-date-formats-processing-level
branch
from
October 23, 2023 08:47
c6be603
to
a2623bc
Compare
danyx23
changed the title
data-page-better-date-formats-processing-level
Better date displays - processing level display
Oct 23, 2023
sophiamersmann
requested changes
Oct 23, 2023
Looks good! I only have a couple of very minor comments. Formatting dates nicely makes a surprisingly big difference :) |
sophiamersmann
approved these changes
Oct 24, 2023
This was referenced Oct 24, 2023
danyx23
deleted the
10-18-data-page-better-date-formats-processing-level
branch
October 24, 2023 16:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the rendering of some dates and time ranges, updates the processing level (minor/major) text and fixes some minor wording issues.
This is related to #2755 and fixes these points:
dataset.update_period_days
and the current date (if it's passed, increase it by a month).10000 BC to 2020 AD
instead of-10000-2020