Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better date displays - processing level display #2801

Merged

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Oct 19, 2023

This PR improves the rendering of some dates and time ranges, updates the processing level (minor/major) text and fixes some minor wording issues.

This is related to #2755 and fixes these points:

  • Instead of mentioning Twitter (in "How to cite this data"), we should say "social media".
  • We should not say "OWID" anywhere (as it happens in "How to cite this data").
  • We should show the date of next expected update. This should be based on dataset.update_period_days and the current date (if it's passed, increase it by a month).
  • Change the wording of "processed" or "adapated" by under the chart to "with minor/major processing by Our World In Data"
  • If the time range for an indicator includes negative years (like our long run population data does), then show 10000 BC to 2020 AD instead of -10000-2020
  • Last updated date should render as a formatted date instead of a raw date string

@danyx23 danyx23 mentioned this pull request Oct 19, 2023
2 tasks
@danyx23 danyx23 force-pushed the 10-17-data-page-key-info branch from ee2568e to 5aaa83c Compare October 20, 2023 13:49
@danyx23 danyx23 force-pushed the 10-18-data-page-better-date-formats-processing-level branch from e69d088 to 1f47473 Compare October 20, 2023 13:49
@danyx23 danyx23 force-pushed the 10-17-data-page-key-info branch from 5aaa83c to f76f08d Compare October 23, 2023 08:08
@danyx23 danyx23 force-pushed the 10-18-data-page-better-date-formats-processing-level branch from 1f47473 to 5e477cc Compare October 23, 2023 08:08
@danyx23 danyx23 force-pushed the 10-17-data-page-key-info branch from f76f08d to 141f81c Compare October 23, 2023 08:12
@danyx23 danyx23 force-pushed the 10-18-data-page-better-date-formats-processing-level branch 2 times, most recently from 2b3b150 to c6be603 Compare October 23, 2023 08:35
@danyx23 danyx23 force-pushed the 10-18-data-page-better-date-formats-processing-level branch from c6be603 to a2623bc Compare October 23, 2023 08:47
@danyx23 danyx23 changed the title data-page-better-date-formats-processing-level Better date displays - processing level display Oct 23, 2023
@danyx23 danyx23 marked this pull request as ready for review October 23, 2023 08:51
site/DataPageV2Content.tsx Show resolved Hide resolved
site/DataPageV2Content.tsx Show resolved Hide resolved
site/DataPageV2Content.tsx Show resolved Hide resolved
site/DataPageV2Content.tsx Show resolved Hide resolved
@sophiamersmann
Copy link
Member

Looks good! I only have a couple of very minor comments. Formatting dates nicely makes a surprisingly big difference :)

Base automatically changed from 10-17-data-page-key-info to master October 24, 2023 16:29
@danyx23 danyx23 merged commit 64c7ba0 into master Oct 24, 2023
13 checks passed
@danyx23 danyx23 deleted the 10-18-data-page-better-date-formats-processing-level branch October 24, 2023 16:29
Copy link
Contributor Author

danyx23 commented Oct 24, 2023

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants