Data pages: extract shared component for sources #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2023
Merged
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
danyx23
force-pushed
the
10-24-data-page-shared-sources
branch
from
99c9648 to
6592aa3
Compare
danyx23
force-pushed
the
10-24-data-page-shared-sources
branch
from
6592aa3 to
1a9bcfc
Compare
danyx23
changed the title
danyx23
force-pushed
the
10-24-data-page-shared-sources
branch
from
1a9bcfc to
0d372d7
Compare
sophiamersmann
approved these changes
Oct 24, 2023
| @@ -1,2 +1,3 @@ | |||
| export const DATAPAGE_SOURCES_AND_PROCESSING_SECTION_ID = | |||
| "sources-and-processing" as const | |||
| export const REUSE_THIS_WORK_SECTION_ID = "reuse-this-work" | |||
There was a problem hiding this comment.
thanks for renaming the file! it really bugged me that I had given it such a generic name...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the block about the sources into a separate component in the components repo