Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skip): statsig integration #739

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

moo-onthelawn
Copy link
Contributor

@moo-onthelawn moo-onthelawn commented Jun 26, 2024

haven't figured out how to get this into the abacus config rip

Integrating Statsig so that we can flag the skip rollout. Done:

  • Adding in statsig client key setting VITE_STATSIG_CLIENT_KEY + adding documentation
  • Creating a StatSigProvider to be used in app
  • Adding SkipMigration flag to AnalyticsProperties
  • Updating UseLocalNotifications to optionally track skip hash

Not done:

  • Getting the statsig config into abacus; will come in follow up

Tested earlier today, but not before I made some changes, will come back and re-test tmrw morn


Constants/Types

  • constants/analytics.ts
    • ffSkipMigration

Hooks

  • hooks/useStatSig
    • wrapper around the statSigProvider
    • Using out of box userId here, no ip address for now
  • hooks/useLocalNotifications
    • update useSkip call here to check flag

Packages

  • @statsig/js-client + @statsig/react-bindings
    • was mentioned as preferable to @statsig/react-sdk which will be deprecated

Testing

  • Tested by verifying flag appropriately set in app during render
  • Verify flag appropriately set in useLocalNotifications
  • Verify analytics have appropriately set skipMigration flag
    • Unsure how to verify this one but I'm fairly confident 🤔 might ask someone here
Screenshot 2024-06-27 at 10 41 24 AM Screenshot 2024-06-27 at 10 41 15 AM

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 9:43pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 9:43pm

Copy link

linear bot commented Jun 26, 2024

src/hooks/useStatsig.tsx Outdated Show resolved Hide resolved
src/hooks/useStatsig.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants