-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix price inputs on sltp for <1 #788
Merged
moo-onthelawn
merged 6 commits into
main
from
mulan/ct-837-fix-input-to-be-more-intuitive-for-tokens-under-1
Jul 12, 2024
Merged
fix: fix price inputs on sltp for <1 #788
moo-onthelawn
merged 6 commits into
main
from
mulan/ct-837-fix-input-to-be-more-intuitive-for-tokens-under-1
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for-tokens-under-1
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
moo-onthelawn
force-pushed
the
mulan/ct-837-fix-input-to-be-more-intuitive-for-tokens-under-1
branch
from
July 11, 2024 16:00
93a1db9
to
d81f246
Compare
aforaleka
approved these changes
Jul 11, 2024
moo-onthelawn
deleted the
mulan/ct-837-fix-input-to-be-more-intuitive-for-tokens-under-1
branch
July 12, 2024 00:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal:
Non-Goal:
Fix:
triggerFormInputs
) instate/inputs.ts
to track the values to visually display vs the ones sent back to abacus (this is the same pattern as what we do for trade - seetradeInputs
)formattedValue
but send back thefloatValue
Note:
isSlTpLimitOrdersEnabled
to betrue
(but orders are not expected to successfully be made, just tested the input)priceInputs.mov
limit.mov
Components
LimitPriceInputs
onLimitInput
to additionally settriggerFormInputs
triggerFormInputs
instead of abacusTriggerOrderInputs
triggerFormInputs
triggerFormInputs
instead of abacususeEffect
hook to update thetriggerFormInputs
from autocalculated price/usdcDiff/percentDiffs from abacusConstants/Types
constants/triggers.ts
CLEARED_TRIGGER_ORDER_INPUTS
andCLEARED_TRIGGER_LIMIT_INPUTS
constsFunctions
lib/abacus/index.ts
clearTriggerOrdersInputValues
to also support just clearing the limit fields, update to also clear thetriggerFormInputs
stateHooks
hooks/useTriggerOrdersFormInputs
triggerFormInputs
when appropriateState
state/inputs.ts
triggerFormInputs
triggerFormInputs
state/inputsSelectors.ts
triggerFormInputs