feat: statsig integration PoC #747

yogurtandjam · 2024-06-28T20:20:09Z

Blocked by dydxprotocol/v4-abacus#489. Will fail CI checks until that PR is merged in and abacus version is bumped

Merges into #739

Builds on @moo-onthelawn's PR by adding a concept of a non-hook based statsig gate request.

It's necessary to do this because we have some abacus initialization we do that requires us to fetch statsig configs within a useEffect hook in order for us to make sure we start up abacus only once (with the correct statsig configs).

Some specifics this PR does:

creates functions to pull in all statsig flags specified in the v4-web repo.
refactors the analytics to pull all statsig configs and once and throw them in. this way devs dont need to update .analytics manually every time they add a flag. this uses the previously mentioned functions
adds a statsig disable flag to allow tests that hit statsig paths to pass.
- we may eventually want to add local overrides
this pr also creates a types folder that will allow us to separate constant values from types. which will help us prevent cyclic dependencies

vercel · 2024-06-28T20:20:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
v4-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 1, 2024 9:00pm
v4-testnet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 1, 2024 9:00pm

test friendly cleanup remove top level await use promises instead of top level await fix add temp hack to silence build error awlways render, otherwise app breaks if no statsig client lint setup statsig depending on abacus comments abstract analytics identifying , use new statsigconfig name

src/types/statsig.ts

moo-onthelawn · 2024-07-01T16:33:04Z

src/lib/statsig.ts

+import { StatsigClient } from '@statsig/js-client';
+
+const fetchIp = async () => {
+  const resp = await fetch('https://api.ipify.org?format=json');


can we move this into useEndpointsConfig? I think it's more secure to do this, also unsure if deployers want to use something diff here

hmm we can... 🤔 but api.ipify.org is a public url so i don't think there's a security concern about exposing this

can update it if you feel strong tho, nw

actually i like this idea a lot - deployers can stand up their own proxy servers this way which i think is totally worth doing if they feel like it - although not sure if we can use hooks in this lib since we're using it in a hook. investigatin 👀

chatted offline; deploying without ip. sounds like we're synced about using the config for the url when we do log ip tho 🫡

src/lib/statsig.ts

moo-onthelawn · 2024-07-01T16:36:18Z

src/lib/statsig.ts

+  return statsigClient;
+};
+
+export const statsigClientPromise = initStatsig();


unsure if we need this const; can we just export initStatsig() instead?

src/hooks/useStatsig.tsx

src/lib/statsig.ts

src/constants/abacus.ts

moo-onthelawn

🚗

…ction

yogurtandjam force-pushed the jerms/462-setup-statsig branch from 543ed7f to 07c3061 Compare June 28, 2024 20:20

vercel bot had a problem deploying to Preview – v4-staging June 28, 2024 20:22 Failure

vercel bot had a problem deploying to Preview – v4-testnet June 28, 2024 20:23 Failure

vercel bot had a problem deploying to Preview – v4-staging June 30, 2024 18:18 Failure

vercel bot had a problem deploying to Preview – v4-testnet June 30, 2024 18:19 Failure

yogurtandjam changed the title ~~[wip] test statsig via abacus usage~~ feat: statsig integration PoC Jun 30, 2024

yogurtandjam changed the base branch from main to mulan/ote-462-abacus-set-up-statsig June 30, 2024 19:39

yogurtandjam changed the base branch from mulan/ote-462-abacus-set-up-statsig to main June 30, 2024 19:39

yogurtandjam changed the base branch from main to mulan/ote-462-abacus-set-up-statsig June 30, 2024 19:39

yogurtandjam force-pushed the jerms/462-setup-statsig branch from a059223 to 3062120 Compare June 30, 2024 19:42

vercel bot had a problem deploying to Preview – v4-staging June 30, 2024 19:43 Failure

yogurtandjam force-pushed the jerms/462-setup-statsig branch from 3062120 to 58d5217 Compare June 30, 2024 19:44

vercel bot had a problem deploying to Preview – v4-testnet June 30, 2024 19:44 Failure

vercel bot had a problem deploying to Preview – v4-staging June 30, 2024 19:45 Failure

yogurtandjam force-pushed the jerms/462-setup-statsig branch from 58d5217 to d389f5d Compare June 30, 2024 19:49

vercel bot had a problem deploying to Preview – v4-testnet June 30, 2024 19:50 Failure

vercel bot had a problem deploying to Preview – v4-staging June 30, 2024 19:51 Failure

yogurtandjam force-pushed the jerms/462-setup-statsig branch from d389f5d to 9061b48 Compare June 30, 2024 19:57

vercel bot had a problem deploying to Preview – v4-staging June 30, 2024 19:58 Failure

vercel bot had a problem deploying to Preview – v4-testnet June 30, 2024 19:59 Failure

vercel bot had a problem deploying to Preview – v4-staging June 30, 2024 20:07 Failure

yogurtandjam marked this pull request as ready for review June 30, 2024 20:07

vercel bot had a problem deploying to Preview – v4-testnet June 30, 2024 20:08 Failure

yogurtandjam requested a review from moo-onthelawn July 1, 2024 15:03

yogurtandjam force-pushed the jerms/462-setup-statsig branch from 5b12acd to 17f3673 Compare July 1, 2024 15:36

move types and enum to constants file

e6c91e7

yogurtandjam force-pushed the jerms/462-setup-statsig branch from 17f3673 to e6c91e7 Compare July 1, 2024 15:37

vercel bot had a problem deploying to Preview – v4-staging July 1, 2024 15:39 Failure

vercel bot had a problem deploying to Preview – v4-staging July 1, 2024 16:41 Failure

vercel bot had a problem deploying to Preview – v4-testnet July 1, 2024 16:42 Failure

moo-onthelawn reviewed Jul 1, 2024

View reviewed changes

vercel bot had a problem deploying to Preview – v4-staging July 1, 2024 17:06 Failure

vercel bot had a problem deploying to Preview – v4-testnet July 1, 2024 17:07 Failure

address comments

8727658

yogurtandjam force-pushed the jerms/462-setup-statsig branch from 54d2a9c to 8727658 Compare July 1, 2024 17:20

vercel bot had a problem deploying to Preview – v4-testnet July 1, 2024 17:21 Failure

vercel bot had a problem deploying to Preview – v4-staging July 1, 2024 17:22 Failure

moo-onthelawn approved these changes Jul 1, 2024

View reviewed changes

bump abacus v. prefer react hook function instead of random async fun…

7f4a5da

…ction

vercel bot deployed to Preview – v4-staging July 1, 2024 20:10 View deployment

vercel bot deployed to Preview – v4-testnet July 1, 2024 20:13 View deployment

vercel bot had a problem deploying to Preview – v4-testnet July 1, 2024 20:18 Failure

vercel bot had a problem deploying to Preview – v4-staging July 1, 2024 20:18 Failure

yogurtandjam force-pushed the jerms/462-setup-statsig branch from e57dcd7 to 213b5c2 Compare July 1, 2024 20:19

vercel bot had a problem deploying to Preview – v4-testnet July 1, 2024 20:20 Failure

fix pnpm v

4ec9b0f

yogurtandjam force-pushed the jerms/462-setup-statsig branch from 213b5c2 to 4ec9b0f Compare July 1, 2024 20:21

vercel bot had a problem deploying to Preview – v4-testnet July 1, 2024 20:21 Failure

vercel bot had a problem deploying to Preview – v4-staging July 1, 2024 20:22 Failure

remove engine i think it breaks builds

f14a6f6

vercel bot deployed to Preview – v4-testnet July 1, 2024 20:37 View deployment

vercel bot deployed to Preview – v4-staging July 1, 2024 20:40 View deployment

address comment

7b355bd

vercel bot deployed to Preview – v4-testnet July 1, 2024 20:58 View deployment

vercel bot deployed to Preview – v4-staging July 1, 2024 21:00 View deployment

yogurtandjam merged commit ffa2f97 into mulan/ote-462-abacus-set-up-statsig Jul 1, 2024
6 checks passed

yogurtandjam deleted the jerms/462-setup-statsig branch July 1, 2024 21:05

yogurtandjam added a commit that referenced this pull request Jul 1, 2024

feat: statsig integration PoC (#747)

0fe66b4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: statsig integration PoC #747

feat: statsig integration PoC #747

yogurtandjam commented Jun 28, 2024 •

edited

Loading

vercel bot commented Jun 28, 2024 •

edited

Loading

moo-onthelawn Jul 1, 2024

yogurtandjam Jul 1, 2024 •

edited

Loading

yogurtandjam Jul 1, 2024 •

edited

Loading

moo-onthelawn Jul 1, 2024

moo-onthelawn Jul 1, 2024

moo-onthelawn left a comment

feat: statsig integration PoC #747

feat: statsig integration PoC #747

Conversation

yogurtandjam commented Jun 28, 2024 • edited Loading

vercel bot commented Jun 28, 2024 • edited Loading

moo-onthelawn Jul 1, 2024

Choose a reason for hiding this comment

yogurtandjam Jul 1, 2024 • edited Loading

Choose a reason for hiding this comment

yogurtandjam Jul 1, 2024 • edited Loading

Choose a reason for hiding this comment

moo-onthelawn Jul 1, 2024

Choose a reason for hiding this comment

moo-onthelawn Jul 1, 2024

Choose a reason for hiding this comment

moo-onthelawn left a comment

Choose a reason for hiding this comment

yogurtandjam commented Jun 28, 2024 •

edited

Loading

vercel bot commented Jun 28, 2024 •

edited

Loading

yogurtandjam Jul 1, 2024 •

edited

Loading

yogurtandjam Jul 1, 2024 •

edited

Loading