Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fade on tradingview chart #783

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

moo-onthelawn
Copy link
Contributor

@moo-onthelawn moo-onthelawn commented Jul 8, 2024

saw it enough recently where it bothered me enough to fix

before after - classic after - light after - dark
Screenshot 2024-07-08 at 5 09 00 PM Screenshot 2024-07-08 at 5 03 27 PM Screenshot 2024-07-08 at 5 03 22 PM Screenshot 2024-07-08 at 5 03 17 PM

I guess it's sorta hard to see my changes just based on how we update tradingview.tgz, but basically

  1. unzipped tradingview.tgz
  2. added the following lines to custom-styles.css
  • Screenshot 2024-07-08 at 5 10 28 PM
  1. zip back up and upload

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 9:21pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 9:21pm

Copy link

linear bot commented Jul 8, 2024

@yogurtandjam
Copy link
Contributor

[q] what is this? happy to stamp bc ur code changes make sense but is a zipped styles file/folder? or what

@moo-onthelawn
Copy link
Contributor Author

moo-onthelawn commented Jul 9, 2024

[q] what is this? happy to stamp bc ur code changes make sense but is a zipped styles file/folder? or what

tradingView is the repo we use for rendering our charts! The zipped folder is basically a fork of the repo, and we've done some custom adjustments for styling purposes (fonts mainly, and themeing colors). (It gets unzipped into public/tradingview if you're ever curious about the contents)

@moo-onthelawn moo-onthelawn merged commit 96645e7 into main Jul 9, 2024
10 checks passed
@moo-onthelawn moo-onthelawn deleted the mulan/ct-994-fix-fade-on-trade-view branch July 9, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants