fix: update staking panel text colors + apr tag #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moo-onthelawn
commented
Jul 3, 2024
•
moo-onthelawn
commented
- Remove the APR badge next to 'Unstaked' and add green APR badge next to 'Staked' (no need to exactly copy Keplr)
- If the balance is more than 0, the text should be 'Primary' instead of 'Tertiary' to avoid confusion (staking panel)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yogurtandjam
approved these changes
Jul 3, 2024
yogurtandjam
reviewed
Jul 3, 2024
| @@ -223,7 +230,15 @@ const $Label = styled.div` | |||
| gap: 0.5rem; | |||
| `; | |||
|
|
|||
| const $BalanceOutput = styled(Output)` | |||
| const $BalanceOutput = styled(Output)<{ isPositive: boolean }>` | |||
There was a problem hiding this comment.
can we infer the color based on the raw value?
like
${({ value})}=> value.gt(0) ... or something?
There was a problem hiding this comment.
ehh hm as personal pref I like to keep the logic in the typescript portion (as opposed to css) but lmk if u feel strongly 👀
This was referenced Jul 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.