Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up isstaking flag, update profile page #774

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

moo-onthelawn
Copy link
Contributor

@moo-onthelawn moo-onthelawn commented Jul 5, 2024

  1. clean up isStakingEnabled (should be true) from env.json (safe as mobile does not use it)
  2. Update ProfilePage with changes discussed here (replace DYDXPanel with StakingPanel, add in ChaosLabs incentives panel)
  3. Remove unused components + pages + reorg structure
// Old Structure
- token/
  - rewards/
  - staking/

// New structure
- token/

New profile page:
Screenshot 2024-07-05 at 2 42 55 PM


Views

  • src/App

    • Always show token page regardless of compliance state since staking enabled token page has read only mode for non full compliance
  • src/layout/Header/HeaderDesktop

    • Always show token page regardless of compliance state since staking enabled token page has read only mode for non full compliance
  • src/pages/Profile`

    • Reorg to replace DYDXBalancePanel with StakingPanel and show LaunchIncentivesPanel

Components

  • Deleted:
    • pages/token/Governance.tsx
    • pages/token/Token.tsx
    • pages/token/rewards/DYDXBalancePanel.tsx
    • pages/token/staking/StakingPage.tsx
    • pages/token/staking/StakingPanel.tsx
    • pages/token/staking/StrideStakingPanel.tsx

Constants/Types

  • constants/routes.ts
    • Remove TokenRoute

Hooks

  • hooks/useEnvFeatures

    • remove isStakingEnabled
  • hooks/useNotificationTypes

    • simplify out isStakingEnabled

Configs

  • v1/env.json
    • Remove isStakingEnabled

Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 9:25pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 9:25pm

@moo-onthelawn moo-onthelawn merged commit 33ff038 into main Jul 8, 2024
7 checks passed
@moo-onthelawn moo-onthelawn deleted the mulan/ote-501-clean-up-isstaking-flag branch July 8, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants