-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(crosswalk_traffic_light_estimator)!: add autoware_ prefix #7365
Merged
yuki-takagi-66
merged 4 commits into
autowarefoundation:main
from
tier4:prefix-crosswalk_traffic_light_estimator
Jun 10, 2024
Merged
refactor(crosswalk_traffic_light_estimator)!: add autoware_ prefix #7365
yuki-takagi-66
merged 4 commits into
autowarefoundation:main
from
tier4:prefix-crosswalk_traffic_light_estimator
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
labels
Jun 7, 2024
yuki-takagi-66
changed the title
crosswalk_traffic_light_estimator
refactor(crosswalk_traffic_light_estimator)!: add autoware_ prefix
Jun 7, 2024
yuki-takagi-66
requested review from
satoshi-ota,
miursh,
tzhong518,
YoshiRi and
yukkysaito
as code owners
June 7, 2024 08:55
yukkysaito
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
satoshi-ota
approved these changes
Jun 7, 2024
satoshi-ota
requested changes
Jun 7, 2024
perception/autoware_crosswalk_traffic_light_estimator/CMakeLists.txt
Outdated
Show resolved
Hide resolved
satoshi-ota
requested changes
Jun 7, 2024
...utoware_crosswalk_traffic_light_estimator/include/crosswalk_traffic_light_estimator/node.hpp
Outdated
Show resolved
Hide resolved
satoshi-ota
approved these changes
Jun 7, 2024
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
force-pushed
the
prefix-crosswalk_traffic_light_estimator
branch
from
June 10, 2024 07:22
ffcfd03
to
4fc3be0
Compare
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 10, 2024
4 tasks
technolojin
added a commit
to technolojin/autoware.universe
that referenced
this pull request
Jun 12, 2024
…refix (autowarefoundation#7365)" This reverts commit d37dbb9.
4 tasks
technolojin
added a commit
to technolojin/autoware.universe
that referenced
this pull request
Jun 12, 2024
…refix (autowarefoundation#7365)" This reverts commit d37dbb9. Signed-off-by: Taekjin LEE <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…7365) * add prefix Signed-off-by: Yuki Takagi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
autoware_
prefix tocrosswalk_traffic_light_estimator
.Part of:
Related links
autowarefoundation/autoware#4569
Tests performed
works well in psim
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.